Fix key duplication/handle camel case names#645
Merged
Conversation
Collaborator
|
Hi, thanks for the fix. I merged 2019 into master and deleted 2019. Could you please change base branch of this PR to master? |
a68a66a to
80b2d41
Compare
Contributor
Author
|
Sorry for the mix-up. It should be set to master now. |
Collaborator
|
Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #629 - duplication of properties when non-pascal case name is used.
I go through existing properties with
Object.keys()and look for a matching key regardless of its casing. If I can find one, I use it. If there isn't one, I default to using pascal case name.Sorry again that it took so long 😓