Add open configuration commands to Command Palette (VSCode)#648
Merged
josefpihrt merged 2 commits intoMar 8, 2020
Merged
Conversation
Collaborator
|
Overally it looks fine. Could you just change |
Contributor
Author
|
Sure thing. I've changed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this contributes Command Palette entries for opening Roslynator's configuration files:
Roslynator: Open Configuration of Analyzers (roslynator.ruleset)andRoslynator: Open Configuration of Refactorings and Fixes (roslynator.config).They create (if necessary - non-existent) configuration files and open them. In practice, they work like built-in
Preferences: Open Settings (JSON)command.You can call them by pressing
Ctrl + Shift + Pand typing their name.This PR also moves omnisharp.json update out of the
extension.tsfile and bumps required VSCode version to be safe (I think I remember that recursive directory creation didn't work in VSCode a year ago, It works now and I'm just not sure when It was added; this PR can be made to work without this change though).You can find tests for this functionality in
openRoslynatorConfiguration.test.ts.Let me know if this is something you'd be open to adding and if I should change/fix something before.