-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Do not merge] Testing how Nanosoldier behaves when testing external stdlibs #59543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@nanosoldier |
The package evaluation job you requested has completed - no new issues were detected. Report summary~ Packages that at least loaded2 packages successfully loaded on the previous version too. |
Hmmm, this doesn't look correct.
It looks like it only tests that it can load Pkg. But we want to actually run the Pkg test suite. |
The logs show the line Based on https://github.com/JuliaCI/PkgEval.jl/blob/master/scripts/evaluate.jl, I think we are hitting https://github.com/JuliaCI/PkgEval.jl/blob/524847dc78c801a51a16ae7e747ebe19f8fc30a4/scripts/evaluate.jl#L184-L185 But this means that So, why is |
I suppose I should write a sentence or two on why I want this to work. Now that we have merged JuliaCI/julia-buildkite#483, external stdlibs will not be tested on PRs to Julia master. So I'd like some way to manually trigger external stdlib tests on a PR. And PkgEval seems like the easiest mechanism to use. |
@nanosoldier |
Your job submission was not accepted. Consult the server logs for more details (cc @maleadt). |
@nanosoldier |
This is frustrating, because I cannot reproduce when I run PkgEval locally. I tested locally with
When I run locally, PkgEval runs the full test suite for the stdlibs that I tried (Pkg and LinearAlgebra). Footnotes
|
The package evaluation job you requested has completed - no new issues were detected. Report summary✖ Packages that failed1 packages failed on the previous version too. ~ Packages that at least loaded1 packages successfully loaded on the previous version too. |
Okay, so this is weird - the problem is happening with CSV.jl too. For CSV.jl (log), it only loaded the package - it didn't run the tests. Why is that happening? |
I wonder if the external stdlibs are getting blacklisted (at least the ones I've tried, Let me try running every stdlib. Surely not all of them have been blacklisted. |
@nanosoldier |
The package evaluation job you requested has completed - no new issues were detected. Report summary✖ Packages that failed2 packages failed on the previous version too. ✔ Packages that passed tests33 packages passed tests on the previous version too. ~ Packages that at least loaded6 packages successfully loaded on the previous version too. |
No description provided.