avoid extra second step when not needed also optimize for performance

archmoj · archmoj · commit 789e7e31f523 · 2020-09-02T12:12:21.000-04:00
diff --git a/src/lib/increment.js b/src/lib/increment.js
@@ -25,12 +25,14 @@ module.exports = function incrementNumeric(x, delta) {
     // Note 2:
     // now we may also consider rounding to cover few more edge cases
     // e.g. 0.3 * 3 = 0.8999999999999999
-    var lenDt = String(delta).length;
-    var lenX0 = String(x).length;
     var lenX1 = String(newX).length;
+    if(lenX1 > 16) {
+        var lenDt = String(delta).length;
+        var lenX0 = String(x).length;
 
-    if(lenX1 >= lenX0 + lenDt) { // likely a rounding error!
-        newX = +parseFloat(newX).toPrecision(12);
+        if(lenX1 >= lenX0 + lenDt) { // likely a rounding error!
+            newX = +parseFloat(newX).toPrecision(12);
+        }
     }
 
     return newX;
