TS: tweaks to 'removed' callback

adumesny · adumesny · commit bec56a99b5f8 · 2020-08-17T09:22:04.000-07:00
*make sure we remove drag&amp;drop handler
* reset el.gridstackNode before callback to let callee know it's going away.
* Only remove if not already done.
diff --git a/src/gridstack.ts b/src/gridstack.ts
@@ -1348,9 +1348,12 @@ export class GridStack {
           gridToNotify._gsEventHandler[event.type](event, target);
         }
         gridToNotify.engine.removedNodes.push(node);
+        gridToNotify.dd.draggable(el, 'destroy').resizable(el, 'destroy');
+        delete el.gridstackNode; // hint we're removing it next and break circular link
         gridToNotify._triggerRemoveEvent();
-        delete el.gridstackNode;
-        el.remove();
+        if (el.parentElement) {
+          el.remove(); // finally remove it
+        }
       } else {
         this._clearRemovingTimeout(el);
         if (!node._temporaryRemoved) {
