Updated Solutions

scottsimpson · scottsimpson · commit c601849b41b5 · 2022-07-22T11:13:57.000-07:00
diff --git a/Solutions/fortune b/Solutions/fortune
@@ -2,12 +2,12 @@
 
 # A fortune-telling game
 
-echo -e "\t\t   Welcome to the "
-echo -e "\t\t🔮 \033[5mMyStIcAl sPhErE\033[0m 🔮"
+echo -e "\t\t   Welcome  to  the "
+echo -e "\t\t🔮 \033[5mMYSTICAL  SPHERE\033[0m 🔮"
 echo
 
-waitingnumber=$(( 0 + $RANDOM % 3 ))
-mysterynumber=$(( 1 + $RANDOM % 10 ))
+waitingnumber=$(( 0 + RANDOM % 3 ))
+mysterynumber=$(( 1 + RANDOM % 10 ))
 
 declare -a fortunes=(
 	"You are likely to achieve the outcome you seek."
@@ -30,5 +30,5 @@ case $waitingnumber in
 esac
 
 echo
-echo ${fortunes[mysterynumber]}
-echo
+echo "${fortunes[mysterynumber]}"
+echo
diff --git a/Solutions/multigame b/Solutions/multigame
@@ -4,8 +4,8 @@
 
 # The game definitions
 guess() {
-	local -i mynumber=$(( 1 + $RANDOM % 10 ))
-	read -p "I'm thinking of a number between 1 and 10. What do you think it is? " theguess
+	local -i mynumber=$(( 1 + RANDOM % 10 ))
+	read -rp "I'm thinking of a number between 1 and 10. What do you think it is? " theguess
 	if (( theguess == mynumber )); then
 		echo "You got it! Great Job!"; echo
 	else
@@ -16,7 +16,7 @@ guess() {
 }
 
 flip() {
-	local -i mynumber=$(( 1 + $RANDOM % 2 ))
+	local -i mynumber=$(( 1 + RANDOM % 2 ))
 	if (( mynumber == 1 )); then
 		local face="HEADS"
 	else
@@ -28,8 +28,8 @@ flip() {
 }
 
 dice() {
-	local -i mynumber=$(( 1 + $RANDOM % 6 ))
-	local -i mynumber2=$(( 1 + $RANDOM % 6 ))
+	local -i mynumber=$(( 1 + RANDOM % 6 ))
+	local -i mynumber2=$(( 1 + RANDOM % 6 ))
 	printf "I rolled two dice and the results are: %s and %s.\n\n" $mynumber $mynumber2
 	sleep 1
 	choosegame
@@ -55,4 +55,4 @@ case $1 in
 	"flip") flip;;
 	"dice") dice;;
 	*) choosegame;;
-esac
+esac
diff --git a/Solutions/sysreport b/Solutions/sysreport
@@ -11,11 +11,10 @@ normal="\033[0m"
 
 printf -v logdate "%(%Y-%m-%d)T"
 
-echo -e $bold"Quick system report for "$greentext"$HOSTNAME"$normal
-printf "\tKernel Release:\t%s\n" $(uname -r)
-printf "\tBash Version:\t%s\n" $BASH_VERSION
-printf "\tFree Storage:\t%s\n" $freespace
-printf "\tFree Memory:\t%s\n" $freemem
-printf "\tFiles in pwd:\t%s\n" $(ls | wc -l)
-printf "\tGenerated on:\t%s\n" $logdate
-
+echo -e "$bold Quick system report for $greentext $HOSTNAME$normal"
+printf "\tKernel Release:\t%s\n" "$(uname -r)"
+printf "\tBash Version:\t%s\n" "$BASH_VERSION"
+printf "\tFree Storage:\t%s\n" "$freespace"
+printf "\tFree Memory:\t%s\n" "$freemem"
+printf "\tFiles in pwd:\t%s\n" "$(ls | wc -l)"
+printf "\tGenerated on:\t%s\n" "$logdate"
