no need to loop over all the traces when waterfallmode is not group

archmoj · archmoj · commit 6b3eeab43c5d · 2019-03-27T14:13:37.000-04:00
diff --git a/src/traces/waterfall/defaults.js b/src/traces/waterfall/defaults.js
@@ -82,11 +82,11 @@ function crossTraceDefaults(fullData, fullLayout) {
         return Lib.coerce(traceOut._input, traceOut, attributes, attr);
     }
 
-    for(var i = 0; i < fullData.length; i++) {
-        traceOut = fullData[i];
+    if(fullLayout.waterfallmode === 'group') {
+        for(var i = 0; i < fullData.length; i++) {
+            traceOut = fullData[i];
+            traceIn = traceOut._input;
 
-        traceIn = traceOut._input;
-        if(fullLayout.waterfallmode === 'group') {
             handleGroupingDefaults(traceIn, traceOut, fullLayout, coerce);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -82,11 +82,11 @@ function crossTraceDefaults(fullData, fullLayout) {`
`82`	`82`	`return Lib.coerce(traceOut._input, traceOut, attributes, attr);`
`83`	`83`	`}`
`84`	`84`
`85`		`- for(var i = 0; i < fullData.length; i++) {`
`86`		`- traceOut = fullData[i];`
	`85`	`+ if(fullLayout.waterfallmode === 'group') {`
	`86`	`+ for(var i = 0; i < fullData.length; i++) {`
	`87`	`+ traceOut = fullData[i];`
	`88`	`+ traceIn = traceOut._input;`
`87`	`89`
`88`		`- traceIn = traceOut._input;`
`89`		`- if(fullLayout.waterfallmode === 'group') {`
`90`	`90`	`handleGroupingDefaults(traceIn, traceOut, fullLayout, coerce);`
`91`	`91`	`}`
`92`	`92`	`}`