fixes timezone offsets in gl3d axes

archmoj · archmoj · commit d23be9921af2 · 2019-03-25T15:59:29.000-04:00
diff --git a/src/plots/cartesian/set_convert.js b/src/plots/cartesian/set_convert.js
@@ -98,7 +98,9 @@ module.exports = function setConvert(ax, fullLayout) {
                 // same logic as in Lib.ms2DateTime
                 var msecTenths = Math.floor(Lib.mod(v + 0.05, 1) * 10);
                 var msRounded = Math.round(v - msecTenths / 10);
-                ms = dateTime2ms(new Date(msRounded)) + msecTenths / 10;
+
+                var now = (new Date(msRounded)).getTime();
+                ms = now + msecTenths / 10;
             }
             else return BADNUM;
         }
diff --git a/test/image/baselines/gl3d_time-offset.png b/test/image/baselines/gl3d_time-offset.png
diff --git a/test/image/mocks/gl3d_time-offset.json b/test/image/mocks/gl3d_time-offset.json
@@ -0,0 +1,25 @@
+{
+    "data": [
+        {
+            "type": "scatter3d",
+            "x": ["2020-01-01 01:00:00", "2020-01-01 13:00:00"],
+            "y": ["2020-01-01 01:00:00", "2020-01-01 02:00:00"],
+            "z": ["2020-01-01 01:00:00", "2020-01-01 01:30:00"]
+        }
+    ],
+    "layout": {
+        "title": "Day time period",
+        "width": 800,
+        "height": 600,
+        "scene": {
+            "xaxis": { "nticks": 12, "type": "date" },
+            "yaxis": { "nticks": 12, "type": "date" },
+            "zaxis": { "nticks": 12, "type": "date" },
+            "camera": {
+                "eye": { "x": -2, "y": 0.5, "z": 1 },
+                "center": { "x": 0, "y": 0, "z": 0 },
+                "up": { "x": 0, "y": 0, "z": 1 }
+            }
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,9 @@ module.exports = function setConvert(ax, fullLayout) {`
`98`	`98`	`// same logic as in Lib.ms2DateTime`
`99`	`99`	`var msecTenths = Math.floor(Lib.mod(v + 0.05, 1) * 10);`
`100`	`100`	`var msRounded = Math.round(v - msecTenths / 10);`
`101`		`- ms = dateTime2ms(new Date(msRounded)) + msecTenths / 10;`
	`101`	`+`
	`102`	`+ var now = (new Date(msRounded)).getTime();`
	`103`	`+ ms = now + msecTenths / 10;`
`102`	`104`	`}`
`103`	`105`	`else return BADNUM;`
`104`	`106`	`}`