Go back to _GLIBCXX_ASSERTIONS; _GLIBCXX_DEBUG causes asan failures

chriselrod · chriselrod · commit d71a52e34c3b · 2023-04-17T22:48:52.000-04:00
Debug lib mallocs, asan frees. Seems asan can't hijack the debug
mallocs, but does hijack the debug fres?
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -155,8 +155,10 @@ if(NOT TEST_INSTALLED_VERSION)
     target_compile_options(LoopModels PUBLIC /W4 /WX)
   endif()
 endif()
-target_compile_options(LoopModels PRIVATE -D_GLIBCXX_DEBUG)
-target_compile_options(${PROJECT_NAME} PRIVATE -D_GLIBCXX_DEBUG)
+# target_compile_options(LoopModels PRIVATE -D_GLIBCXX_DEBUG) target_compile_options(${PROJECT_NAME}
+# PRIVATE -D_GLIBCXX_DEBUG)
+target_compile_options(LoopModels PRIVATE -D_GLIBCXX_ASSERTIONS)
+target_compile_options(${PROJECT_NAME} PRIVATE -D_GLIBCXX_ASSERTIONS)
 
 # ---- code coverage ----
 
diff --git a/test/TestUtilities.hpp b/test/TestUtilities.hpp
@@ -30,8 +30,8 @@ class TestLoopFunction {
   llvm::Function *F;
   llvm::DataLayout dl;
   llvm::TargetTransformInfo TTI;
-  llvm::Triple targetTripple;
-  llvm::TargetLibraryInfoImpl TLII;
+  llvm::Triple targetTripple{};
+  // llvm::TargetLibraryInfoImpl TLII;
   llvm::TargetLibraryInfo TLI;
   llvm::AssumptionCache AC;
   llvm::ScalarEvolution SE;
@@ -92,8 +92,9 @@ class TestLoopFunction {
                                  llvm::SmallVector<llvm::Type *, 0>(), false)},
       F{llvm::Function::Create(
         FT, llvm::GlobalValue::LinkageTypes::ExternalLinkage, "foo", mod)},
-      dl{mod}, TTI{dl}, TLII{targetTripple}, TLI{TLII}, AC{*F, &TTI},
-      SE{*F, TLI, AC, DT, LI}, BB{llvm::BasicBlock::Create(ctx, "entry", F)},
+      dl{mod}, TTI{dl}, TLI{llvm::TargetLibraryInfoImpl{targetTripple}, F},
+      AC{*F, &TTI}, SE{*F, TLI, AC, DT, LI},
+      BB{llvm::BasicBlock::Create(ctx, "entry", F)},
       builder{llvm::IRBuilder(BB)} {
 
     auto fmf{llvm::FastMathFlags()};
diff --git a/test/remarks_test.cpp b/test/remarks_test.cpp
@@ -21,13 +21,14 @@ TEST(Remarks, BasicAssertions) {
   //         "../../test/examples/%s.ll 2>&1 | head -n300 | diff "
   //         "../../test/examples/%s.txt -",
   //         testfile, testfile);
-  sprintf(bufopt.data(),
-          "opt -mcpu=skylake-avx512 --disable-output "
-          "-load-pass-plugin=_deps/loopmodels-build/libLoopModels.so "
-          "-passes=turbo-loop -pass-remarks-analysis=turbo-loop "
-          "../../test/examples/%s.ll 2>&1 | sdiff -l - "
-          "../../test/examples/%s.txt",
-          testfile, testfile);
+  sprintf(
+    bufopt.data(),
+    "LD_PRELOAD=/usr/lib64/libasan.so.8 opt -mcpu=skylake-avx512 "
+    "--disable-output "
+    "-load-pass-plugin=_deps/loopmodels-build/libLoopModels.so "
+    "-passes=turbo-loop -pass-remarks-analysis=turbo-loop "
+    "../../test/examples/%s.ll 2>&1 | sdiff -l - ../../test/examples/%s.txt",
+    testfile, testfile);
 
   int rc = system(bufopt.data());
   EXPECT_EQ(rc, 0);
