[#137] Fix not using the adapter's cache item

juampynr · web-flow · commit 97d3b017b6f6 · 2018-07-05T12:42:47.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
   parameter. #135
 - A custom field class is loaded in objects even if the response data does not
   contain any fields in that namespace. #135
+- Fix not using the adapter's cache item #137
 
 ## [0.5.0] - 2018-06-21
 
diff --git a/src/Service/AccessManagement/ResolveDomain.php b/src/Service/AccessManagement/ResolveDomain.php
@@ -2,7 +2,6 @@
 
 namespace Lullabot\Mpx\Service\AccessManagement;
 
-use Cache\Adapter\Common\CacheItem;
 use Lullabot\Mpx\DataService\IdInterface;
 use Lullabot\Mpx\Normalizer\UriNormalizer;
 use Symfony\Component\Serializer\Encoder\JsonEncoder;
@@ -58,7 +57,6 @@ public function resolve(IdInterface $account): ResolveDomainResponse
         $serializer = new Serializer($normalizers, $encoders);
 
         $resolved = $serializer->deserialize($response->getBody(), ResolveDomainResponse::class, 'json');
-        $item = new CacheItem($key);
         $item->set($resolved);
 
         // thePlatform provides no guidance on how long we can cache this for.
diff --git a/tests/src/Unit/Service/AccessManagement/ResolveDomainTest.php b/tests/src/Unit/Service/AccessManagement/ResolveDomainTest.php
@@ -88,10 +88,9 @@ public function testResolveCache()
 
         $cache->expects($this->once())->method('save');
 
-        $item->expects($this->at(0))->method('isHit')
-            ->willReturn(false);
-        $item->expects($this->at(1))->method('isHit')
-            ->willReturn(true);
+        $item->expects($this->exactly(2))->method('isHit')
+            ->willReturnOnConsecutiveCalls(false, true);
+        $item->expects($this->at(0))->method('set');
 
         $resolveDomain = new ResolveDomain($authenticatedClient, $cache);
 
