Thanks to visit codestin.com
Credit goes to github.com

Skip to content

scipy dependency #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DSamuylov opened this issue Sep 2, 2017 · 3 comments
Closed

scipy dependency #72

DSamuylov opened this issue Sep 2, 2017 · 3 comments

Comments

@DSamuylov
Copy link

From setup.py file:

    install_requires=[
        'nose>=1.3.7',
        'numpy>=1.11.0',
        'matplotlib>=1.5.1',
        'requests>=2.10.0',
        'pandas>=0.19.1',
        'scipy==0.19.0'
        ],

Why do you restrict the version of scipy to be 0.19.0? Is there any reasons why it wouldn't work with a newer version? Or is it just a typo?
@Dubrzr
Copy link
Collaborator

Dubrzr commented Sep 3, 2017

Hi Denis,
Primarily for compatibility reasons as a future version could be incompatible, but in fact, we have a CI that tests every commit we do so this can be changed to >=
Is it a problem for you?

@DSamuylov
Copy link
Author

Thank you for your prompt reply, @Dubrzr!
It is just interesting, why is it different for example for numpy? I wondering what happens if a different package depends on a newer version of scipy. While installing wfdb-python, the newest version of scipy has been removed. So, it would break/remove other packages that need it. I think it would be great to have >= for all dependencies. Does scipy has some APIs that you rely on, but can be changed in future releases?

@Dubrzr
Copy link
Collaborator

Dubrzr commented Sep 4, 2017

It is simply different because of the habits of two different developers (me and cx1111) : check the git blame at https://github.com/MIT-LCP/wfdb-python/blame/master/setup.py#L60. But you are right, this could break other packages that need it.

@Dubrzr Dubrzr closed this as completed in 2b62c15 Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dubrzr @DSamuylov