Merge pull request atom#1448 from atom/aw/return-non-match-singleton

smashwilson · web-flow · commit 9aa3715183db · 2018-05-07T10:40:50.000-04:00
URIPattern.match() returns a URIMatch
diff --git a/lib/atom/uri-pattern.js b/lib/atom/uri-pattern.js
@@ -59,7 +59,7 @@ export default class URIPattern {
 
   matches(string) {
     if (string === undefined || string === null) {
-      return false;
+      return nonURIMatch;
     }
 
     const other = url.parse(string, true);
diff --git a/test/atom/uri-pattern.test.js b/test/atom/uri-pattern.test.js
@@ -20,8 +20,8 @@ describe('URIPattern', function() {
     });
 
     it('does not match undefined or null', function() {
-      assert.isFalse(exact.matches(undefined));
-      assert.isFalse(exact.matches(null));
+      assert.isFalse(exact.matches(undefined).ok());
+      assert.isFalse(exact.matches(null).ok());
     });
   });
 

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export default class URIPattern {`
`59`	`59`
`60`	`60`	`matches(string) {`
`61`	`61`	`if (string === undefined \|\| string === null) {`
`62`		`- return false;`
	`62`	`+ return nonURIMatch;`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`const other = url.parse(string, true);`