Thanks to visit codestin.com
Credit goes to github.com

Skip to content

all.sh inconsistencies about generated files #188

@gilles-peskine-arm

Description

@gilles-peskine-arm

all.sh starts every component with the configuration-independent platform-independent generated files present in Mbed TLS (both 3.6 and 4.x), but not in TF-PSA-Crypto. This means that the same component code in the two repositories can have different effects. For example, in TF-PSA-Crypto, check_test_cases misses the generated test cases, and check_names may miss some things (resulting in false positives or false negatives) if we forget to generate enough files.

Cleanup before components does not remove generated files. Thus, in TF-PSa-Crypto, when we run a component locally, we may run it in a different state from the CI if we happen to have some generated test cases present. If in the future we group multiple components in the same node instantiation on the CI, components may run in a variable state (with or without generated files present).

Historically, when we first introduced generated files, not all builds could cope with them (at first only Make was supported but not CMake), so all.sh prepared the generated files. We've moved on from that, and now every build should be able to cope with a fresh checkout where the generated files are missing. (Builds should also cope with generated files being present, but that's usually not a problem.) However, some of the checks that don't do builds assume that the generated files are present.

I'm not sure what the right thing is, but it should be consistent across repositories and invocation scenarios.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    Status

    Unsorted

    Status

    Unsorted

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions