Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add support for eslint-plugin-playwright #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

georgi-mateev
Copy link
Collaborator

@georgi-mateev georgi-mateev commented Jan 9, 2024

Pull Request

Description

Add support for eslint-plugin-playwright

Related Issue

Resolves #185

Checklist

  • Add needsPlaywright as param for renderEslint()
  • Add eslint-plugin-playwright as dev dependency
  • Add it to eslint config under the extends key

Screenshots (if applicable)

playwright-eslint eslint-plugin-playwright

Additional Comments

One thing we should be careful of is not overriding already existing data when adding multiple items to a single config key, as example both playwright and vuejs-accessibility attach on the extends key of the eslintrc.cjs.

@georgi-mateev georgi-mateev added the enhancement New feature or request label Jan 9, 2024
@georgi-mateev georgi-mateev added this to the v0.5 milestone Jan 9, 2024
@georgi-mateev georgi-mateev self-assigned this Jan 9, 2024
@georgi-mateev georgi-mateev linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@Yordan-Ramchev Yordan-Ramchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Yordan-Ramchev Yordan-Ramchev merged commit 40f594b into main Jan 12, 2024
@Yordan-Ramchev Yordan-Ramchev deleted the 185-eslint-plugin-playwright branch January 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESlint plugin playwright
2 participants