|
| 1 | +# PR Summary |
| 2 | + |
| 3 | +Code Reviewer: <!-- CR id, filled by SSD --> |
| 4 | + |
| 5 | +<!-- To be completed by the developer --> |
| 6 | + |
| 7 | +<!-- Provide a brief description of the changes in this PR, including any notes |
| 8 | + useful for reviewers --> |
| 9 | + |
| 10 | +<!-- List any linked PRs here |
| 11 | +- linked MetOffice/<REPO-NAME>#<pr-number> |
| 12 | +--> |
| 13 | + |
| 14 | +<!-- List any blocking PRs or issues to be closed here |
| 15 | +- is blocked-by #pr-number |
| 16 | +- blocks #pr-number |
| 17 | +- closes #issue-number |
| 18 | +- fixes #issue-number |
| 19 | +- is related to #issue-number |
| 20 | +--> |
| 21 | + |
| 22 | +## Code Quality Checklist |
| 23 | + |
| 24 | +(_Some checks are automatically carried out via the CI pipeline_) |
| 25 | + |
| 26 | +- [ ] I have performed a self-review of my own code |
| 27 | +- [ ] My code follows the project's style guidelines |
| 28 | +- [ ] Comments have been included that aid undertanding and enhance the |
| 29 | + readability of the code |
| 30 | +- [ ] My changes generate no new warnings |
| 31 | + |
| 32 | +## Testing |
| 33 | + |
| 34 | +- [ ] I have tested this change locally, using the rose-stem suite |
| 35 | +- [ ] If any tests fail (rose-stem or CI) the reason is understood and |
| 36 | + acceptable (eg. kgo changes) |
| 37 | +- [ ] I have added tests to cover new functionality as appropriate (eg. system |
| 38 | + tests, unit tests, etc.) |
| 39 | + |
| 40 | +<!-- Describe other testing performed (if applicable) --> |
| 41 | + |
| 42 | +### trac.log |
| 43 | + |
| 44 | +<!-- Paste your trac.log from testing output here --> |
| 45 | + |
| 46 | +## Security Considerations |
| 47 | + |
| 48 | +- [ ] This change does not introduce security vulnerabilities |
| 49 | +- [ ] I have reviewed the code for potential security issues |
| 50 | +- [ ] Sensitive data is properly handled (if applicable) |
| 51 | +- [ ] Authentication and authorisation are properly implemented (if applicable) |
| 52 | + |
| 53 | +## Performance Impact |
| 54 | + |
| 55 | +- [ ] Performance of the code has been considered and, if applicable, suitable |
| 56 | + performance measurements have been conducted |
| 57 | + |
| 58 | +## Contributor License Agreement (CLA) |
| 59 | + |
| 60 | +- [ ] **Required** - I confirm that I have read and agree to the project's |
| 61 | + [Contributor License Agreement](todo-enter-link-to-cla) |
| 62 | + |
| 63 | +## AI Assistance and Attribution |
| 64 | + |
| 65 | +- [ ] Some of the content of this change has been produced with the assistance |
| 66 | + of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise, |
| 67 | + Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the |
| 68 | + [Simulation Systems AI policy](todo-enter-link-to-policy-page) (including |
| 69 | + attribution labels) |
| 70 | + |
| 71 | +## Documentation |
| 72 | + |
| 73 | +- [ ] Where appropriate I have updated documentation related to this change and |
| 74 | + confirmed that it builds correctly |
| 75 | + |
| 76 | +# Code Review |
| 77 | + |
| 78 | +<!-- To be completed by the Code Reviewer --> |
| 79 | + |
| 80 | +- [ ] All dependencies have been resolved |
| 81 | +- [ ] Related Issues are properly linked and addressed |
| 82 | +- [ ] CLA compliance is confirmed |
| 83 | +- [ ] Code quality standards are met |
| 84 | +- [ ] Tests are adequate and passing |
| 85 | +- [ ] Documentation is complete and accurate |
| 86 | +- [ ] Security considerations have been addressed |
| 87 | +- [ ] Performance impact is acceptable |
0 commit comments