Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Review pull request resets comment when switching response type #8451

@xmatthias

Description

@xmatthias
  • Extension version: 0.127.2026013004
  • VSCode Version: 1.108.1
  • OS: linux
  • Repository Clone Configuration (single repository/fork of an upstream repository):
  • GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): github.com

Steps to Reproduce:

  1. Review a Pull request, try to add the "final" comment via the extension
  2. Type a comment, before posting change from "comment" to "request changes" or similar
  3. Note comment resetting after changing the "comment" mode
  4. Also note that changing to "request changes" or "comment" isn't possible while the text field is empty

Especially the last point is problematic - as it means that i must type a comment beforehand - BUT i also must copy the comment to actually keep it.

For context: this is a PR i've made about 2 comments beforehand - so on the github UI, i can

Image

edit i noticed that switching from "comment" to "review" actually posts the comment - which is even worse - as i expected this to switch to the other mode (just as the github UI does) - and then expect a click on the actual button to post the review!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions