[X64] [EgorBo] Expand String.EndsWith/MemoryExtensions.EndsWith in JIT #255
Description
Build completed in 1 hour 41 minutes.
dotnet/runtime#98593
CoreLib diffs
Found 2 files with textual diffs.
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 7342807
Total bytes of diff: 7342548
Total bytes of delta: -259 (-0.00 % of base)
Total relative delta: 0.27
diff is an improvement.
relative diff is a regression.
Total byte diff includes -341 bytes from reconciling methods
Base had 1 unique methods, 341 unique bytes
Diff had 0 unique methods, 0 unique bytes
Top file improvements (bytes):
-259 : System.Private.CoreLib.dasm (-0.00 % of base)
1 total files with Code Size differences (1 improved, 0 regressed), 0 unchanged.
Top method regressions (bytes):
70 (23.18 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:AttributeTypeNamesMatch(System.Type,System.Type):ubyte (FullOpts)
30 (5.99 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.ActivityTracker:NormalizeActivityName(System.String,System.String,int):System.String (FullOpts)
26 (3.85 % of base) : System.Private.CoreLib.dasm - System.StartupHookProvider:ParseStartupHook(byref,System.String) (FullOpts)
21 (2.29 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:ResolveSatelliteAssembly(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts)
1 (0.36 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.DebugProvider:Write(System.String):this (FullOpts)
Top method improvements (bytes):
-341 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Globalization.Ordinal:EqualsIgnoreCase_Vector[System.Runtime.Intrinsics.Vector256`1[ushort]](byref,byref,int):ubyte (FullOpts) (1 base, 0 diff methods)
-41 (-0.79 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):ubyte[] (FullOpts)
-7 (-0.80 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetFirstResolvedAssemblyFromResolvingEvent(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts)
-7 (-3.06 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetResolvedUnmanagedDll(System.Reflection.Assembly,System.String):long:this (FullOpts)
-7 (-0.78 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:InvokeResolveEvent(System.ResolveEventHandler,System.Reflection.RuntimeAssembly,System.String):System.Reflection.RuntimeAssembly (FullOpts)
-4 (-3.31 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:GetOpcodeWithDefault(int,System.String):int (FullOpts)
Top method regressions (percentages):
70 (23.18 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:AttributeTypeNamesMatch(System.Type,System.Type):ubyte (FullOpts)
30 (5.99 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.ActivityTracker:NormalizeActivityName(System.String,System.String,int):System.String (FullOpts)
26 (3.85 % of base) : System.Private.CoreLib.dasm - System.StartupHookProvider:ParseStartupHook(byref,System.String) (FullOpts)
21 (2.29 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:ResolveSatelliteAssembly(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts)
1 (0.36 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.DebugProvider:Write(System.String):this (FullOpts)
Top method improvements (percentages):
-341 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Globalization.Ordinal:EqualsIgnoreCase_Vector[System.Runtime.Intrinsics.Vector256`1[ushort]](byref,byref,int):ubyte (FullOpts) (1 base, 0 diff methods)
-4 (-3.31 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:GetOpcodeWithDefault(int,System.String):int (FullOpts)
-7 (-3.06 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetResolvedUnmanagedDll(System.Reflection.Assembly,System.String):long:this (FullOpts)
-7 (-0.80 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetFirstResolvedAssemblyFromResolvingEvent(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts)
-41 (-0.79 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):ubyte[] (FullOpts)
-7 (-0.78 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:InvokeResolveEvent(System.ResolveEventHandler,System.Reflection.RuntimeAssembly,System.String):System.Reflection.RuntimeAssembly (FullOpts)
11 total methods with Code Size differences (6 improved, 5 regressed), 56271 unchanged.
--------------------------------------------------------------------------------
Frameworks diffs
Diffs
Found 267 files with textual diffs.
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 38806380
Total bytes of diff: 38806279
Total bytes of delta: -101 (-0.00 % of base)
Total relative delta: 0.48
diff is an improvement.
relative diff is a regression.
Total byte diff includes -341 bytes from reconciling methods
Base had 1 unique methods, 341 unique bytes
Diff had 0 unique methods, 0 unique bytes
Top file regressions (bytes):
69 : System.Private.Xml.dasm (0.00 % of base)
30 : System.IO.Packaging.dasm (0.03 % of base)
24 : System.Net.Http.dasm (0.00 % of base)
23 : System.Net.Ping.dasm (0.05 % of base)
21 : System.IO.Ports.dasm (0.04 % of base)
5 : System.Reflection.MetadataLoadContext.dasm (0.00 % of base)
Top file improvements (bytes):
-238 : System.Private.CoreLib.dasm (-0.00 % of base)
-18 : System.Diagnostics.FileVersionInfo.dasm (-0.18 % of base)
-17 : System.Private.DataContractSerialization.dasm (-0.00 % of base)
9 total files with Code Size differences (3 improved, 6 regressed), 247 unchanged.
Top method regressions (bytes):
70 (23.18 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:AttributeTypeNamesMatch(System.Type,System.Type):ubyte (FullOpts)
41 (6.61 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PackUriHelper+ValidatedPartUri:IsRelationshipUri():ubyte:this (FullOpts)
30 (5.99 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.ActivityTracker:NormalizeActivityName(System.String,System.String,int):System.String (FullOpts)
28 (4.20 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:ImportAttributeMember(System.Xml.Schema.XmlSchemaAttribute,System.String,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.CodeIdentifiers,System.String):this (FullOpts)
28 (2.48 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:ImportElementMember(System.Xml.Schema.XmlSchemaElement,System.String,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.INameScope,System.String,ubyte,byref,ubyte,ubyte):this (FullOpts)
26 (3.85 % of base) : System.Private.CoreLib.dasm - System.StartupHookProvider:ParseStartupHook(byref,System.String) (FullOpts)
24 (0.63 % of base) : System.Net.Http.dasm - System.Net.Http.AuthenticationHelper+<GetDigestTokenForCredential>d__40:MoveNext():this (FullOpts)
23 (16.67 % of base) : System.Net.Ping.dasm - System.Net.NetworkInformation.UnixCommandLinePing:IsBusyboxPing(System.String):ubyte (FullOpts)
21 (3.04 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialPort:GetPortNames_FreeBSD():System.String[] (FullOpts)
21 (2.29 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:ResolveSatelliteAssembly(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts)
20 (0.86 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WriteSourceBegin(System.String):this (FullOpts)
20 (0.99 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WriteSourceEnd(System.String,System.Type,System.Type):this (FullOpts)
5 (0.11 % of base) : System.Reflection.MetadataLoadContext.dasm - System.Reflection.TypeLoading.RoType:GetMemberImpl(System.String,int,int):System.Reflection.MemberInfo[]:this (FullOpts)
1 (0.36 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.DebugProvider:Write(System.String):this (FullOpts)
Top method improvements (bytes):
-341 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Globalization.Ordinal:EqualsIgnoreCase_Vector[System.Runtime.Intrinsics.Vector256`1[ushort]](byref,byref,int):ubyte (FullOpts) (1 base, 0 diff methods)
-41 (-0.79 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):ubyte[] (FullOpts)
-27 (-6.75 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.CodeIdentifier:EscapeKeywords(System.String,System.Text.StringBuilder) (FullOpts)
-18 (-0.91 % of base) : System.Diagnostics.FileVersionInfo.dasm - System.Diagnostics.FileVersionInfo:LoadManagedAssemblyMetadata(System.Reflection.Metadata.MetadataReader,ubyte):this (FullOpts)
-17 (-1.55 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.JsonReaderDelegator:ParseJsonDateInDefaultFormat(System.String):System.DateTime (FullOpts)
-11 (-9.57 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.ZipPackage:IsZipItemValidOpcPartOrPiece(System.String):ubyte (FullOpts)
-4 (-3.31 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:GetOpcodeWithDefault(int,System.String):int (FullOpts)
Top method regressions (percentages):
70 (23.18 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:AttributeTypeNamesMatch(System.Type,System.Type):ubyte (FullOpts)
23 (16.67 % of base) : System.Net.Ping.dasm - System.Net.NetworkInformation.UnixCommandLinePing:IsBusyboxPing(System.String):ubyte (FullOpts)
41 (6.61 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.PackUriHelper+ValidatedPartUri:IsRelationshipUri():ubyte:this (FullOpts)
30 (5.99 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.ActivityTracker:NormalizeActivityName(System.String,System.String,int):System.String (FullOpts)
28 (4.20 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:ImportAttributeMember(System.Xml.Schema.XmlSchemaAttribute,System.String,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.CodeIdentifiers,System.String):this (FullOpts)
26 (3.85 % of base) : System.Private.CoreLib.dasm - System.StartupHookProvider:ParseStartupHook(byref,System.String) (FullOpts)
21 (3.04 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialPort:GetPortNames_FreeBSD():System.String[] (FullOpts)
28 (2.48 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:ImportElementMember(System.Xml.Schema.XmlSchemaElement,System.String,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.CodeIdentifiers,System.Xml.Serialization.INameScope,System.String,ubyte,byref,ubyte,ubyte):this (FullOpts)
21 (2.29 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:ResolveSatelliteAssembly(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts)
20 (0.99 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WriteSourceEnd(System.String,System.Type,System.Type):this (FullOpts)
20 (0.86 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WriteSourceBegin(System.String):this (FullOpts)
24 (0.63 % of base) : System.Net.Http.dasm - System.Net.Http.AuthenticationHelper+<GetDigestTokenForCredential>d__40:MoveNext():this (FullOpts)
1 (0.36 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.DebugProvider:Write(System.String):this (FullOpts)
5 (0.11 % of base) : System.Reflection.MetadataLoadContext.dasm - System.Reflection.TypeLoading.RoType:GetMemberImpl(System.String,int,int):System.Reflection.MemberInfo[]:this (FullOpts)
Top method improvements (percentages):
-341 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Globalization.Ordinal:EqualsIgnoreCase_Vector[System.Runtime.Intrinsics.Vector256`1[ushort]](byref,byref,int):ubyte (FullOpts) (1 base, 0 diff methods)
-11 (-9.57 % of base) : System.IO.Packaging.dasm - System.IO.Packaging.ZipPackage:IsZipItemValidOpcPartOrPiece(System.String):ubyte (FullOpts)
-27 (-6.75 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.CodeIdentifier:EscapeKeywords(System.String,System.Text.StringBuilder) (FullOpts)
-4 (-3.31 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:GetOpcodeWithDefault(int,System.String):int (FullOpts)
-17 (-1.55 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.JsonReaderDelegator:ParseJsonDateInDefaultFormat(System.String):System.DateTime (FullOpts)
-18 (-0.91 % of base) : System.Diagnostics.FileVersionInfo.dasm - System.Diagnostics.FileVersionInfo:LoadManagedAssemblyMetadata(System.Reflection.Metadata.MetadataReader,ubyte):this (FullOpts)
-41 (-0.79 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:CreateManifestAndDescriptors(System.Type,System.String,System.Diagnostics.Tracing.EventSource,int):ubyte[] (FullOpts)
21 total methods with Code Size differences (7 improved, 14 regressed), 239166 unchanged.
--------------------------------------------------------------------------------
Artifacts:
- build-artifacts-main.zip (663 MB)
- build-clr-checked-main.zip (74 MB)
- build-artifacts-pr.zip (663 MB)
- build-clr-checked-pr.zip (74 MB)
- jit-diffs-corelib.zip (48 MB)
- diff-corelib.txt (4 KB)
- jit-diffs-frameworks.zip (251 MB)
- diff-frameworks.txt (9 KB)
- build-logs.txt (1 MB)