Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[X64] [stephentoub] Remove some volatile use on objects in corelib #357

@MihuBot

Description

@MihuBot

Build completed in 28 minutes.
dotnet/runtime#100969

Diffs

Found 268 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 38844454
Total bytes of diff: 38844340
Total bytes of delta: -114 (-0.00 % of base)
Total relative delta: 0.08
    diff is an improvement.
    relative diff is a regression.


Top file improvements (bytes):
        -114 : System.Private.CoreLib.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 255 unchanged.

Top method regressions (bytes):
          19 (33.33 % of base) : System.Private.CoreLib.dasm - System.Type:get_DefaultBinder():System.Reflection.Binder (FullOpts)
          10 (10.31 % of base) : System.Private.CoreLib.dasm - System.Globalization.CultureInfo:get_CachedCulturesByLcid():System.Collections.Generic.Dictionary`2[int,System.Globalization.CultureInfo] (FullOpts)
          10 (10.31 % of base) : System.Private.CoreLib.dasm - System.Globalization.CultureInfo:get_CachedCulturesByName():System.Collections.Generic.Dictionary`2[System.String,System.Globalization.CultureInfo] (FullOpts)

Top method improvements (bytes):
         -53 (-4.31 % of base) : System.Private.CoreLib.dasm - System.Threading.ManualResetEventSlim:Wait(int,System.Threading.CancellationToken):ubyte:this (FullOpts)
         -38 (-3.21 % of base) : System.Private.CoreLib.dasm - System.Globalization.CultureData:CreateCultureWithInvariantData():System.Globalization.CultureData (FullOpts)
         -21 (-3.21 % of base) : System.Private.CoreLib.dasm - System.Globalization.JapaneseCalendar:GetEraInfo():System.Globalization.EraInfo[] (FullOpts)
         -11 (-7.69 % of base) : System.Private.CoreLib.dasm - System.Text.EncodingProvider:GetEncodingFromProvider(int,System.Text.EncoderFallback,System.Text.DecoderFallback):System.Text.Encoding (FullOpts)
         -11 (-7.69 % of base) : System.Private.CoreLib.dasm - System.Text.EncodingProvider:GetEncodingFromProvider(System.String,System.Text.EncoderFallback,System.Text.DecoderFallback):System.Text.Encoding (FullOpts)
         -11 (-10.00 % of base) : System.Private.CoreLib.dasm - System.Text.EncodingProvider:GetEncodingFromProvider(System.String):System.Text.Encoding (FullOpts)
          -7 (-8.75 % of base) : System.Private.CoreLib.dasm - System.Threading.ManualResetEventSlim:EnsureLockObjectCreated():this (FullOpts)
          -1 (-0.93 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:get_AllContexts():System.Collections.Generic.Dictionary`2[long,System.WeakReference`1[System.Runtime.Loader.AssemblyLoadContext]] (FullOpts)

Top method regressions (percentages):
          19 (33.33 % of base) : System.Private.CoreLib.dasm - System.Type:get_DefaultBinder():System.Reflection.Binder (FullOpts)
          10 (10.31 % of base) : System.Private.CoreLib.dasm - System.Globalization.CultureInfo:get_CachedCulturesByLcid():System.Collections.Generic.Dictionary`2[int,System.Globalization.CultureInfo] (FullOpts)
          10 (10.31 % of base) : System.Private.CoreLib.dasm - System.Globalization.CultureInfo:get_CachedCulturesByName():System.Collections.Generic.Dictionary`2[System.String,System.Globalization.CultureInfo] (FullOpts)

Top method improvements (percentages):
         -11 (-10.00 % of base) : System.Private.CoreLib.dasm - System.Text.EncodingProvider:GetEncodingFromProvider(System.String):System.Text.Encoding (FullOpts)
          -7 (-8.75 % of base) : System.Private.CoreLib.dasm - System.Threading.ManualResetEventSlim:EnsureLockObjectCreated():this (FullOpts)
         -11 (-7.69 % of base) : System.Private.CoreLib.dasm - System.Text.EncodingProvider:GetEncodingFromProvider(int,System.Text.EncoderFallback,System.Text.DecoderFallback):System.Text.Encoding (FullOpts)
         -11 (-7.69 % of base) : System.Private.CoreLib.dasm - System.Text.EncodingProvider:GetEncodingFromProvider(System.String,System.Text.EncoderFallback,System.Text.DecoderFallback):System.Text.Encoding (FullOpts)
         -53 (-4.31 % of base) : System.Private.CoreLib.dasm - System.Threading.ManualResetEventSlim:Wait(int,System.Threading.CancellationToken):ubyte:this (FullOpts)
         -38 (-3.21 % of base) : System.Private.CoreLib.dasm - System.Globalization.CultureData:CreateCultureWithInvariantData():System.Globalization.CultureData (FullOpts)
         -21 (-3.21 % of base) : System.Private.CoreLib.dasm - System.Globalization.JapaneseCalendar:GetEraInfo():System.Globalization.EraInfo[] (FullOpts)
          -1 (-0.93 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:get_AllContexts():System.Collections.Generic.Dictionary`2[long,System.WeakReference`1[System.Runtime.Loader.AssemblyLoadContext]] (FullOpts)

11 total methods with Code Size differences (8 improved, 3 regressed), 239826 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions