Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 82090ee

Browse files
committed
Change ordering of ReviewComment fields
1 parent 747eb42 commit 82090ee

File tree

1 file changed

+19
-18
lines changed

1 file changed

+19
-18
lines changed

src/GitHub/Data/Reviews.hs

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ instance FromJSON Review where
5555
o .: "id"
5656

5757
data ReviewComment = ReviewComment
58-
{ reviewCommentBody :: !Text
58+
{ reviewCommentId :: !(Id ReviewComment)
59+
, reviewCommentUser :: !SimpleUser
60+
, reviewCommentBody :: !Text
5961
, reviewCommentUrl :: !URL
6062
, reviewCommentPullRequestReviewId :: !(Id Review)
6163
, reviewCommentDiffHunk :: !Text
@@ -68,8 +70,6 @@ data ReviewComment = ReviewComment
6870
, reviewCommentUpdatedAt :: !UTCTime
6971
, reviewCommentHtmlUrl :: !URL
7072
, reviewCommentPullRequestUrl :: !URL
71-
, reviewCommentUser :: !SimpleUser
72-
, reviewCommentId :: !(Id ReviewComment)
7373
} deriving (Show, Generic)
7474

7575
instance NFData ReviewComment where
@@ -79,18 +79,19 @@ instance Binary ReviewComment
7979

8080
instance FromJSON ReviewComment where
8181
parseJSON =
82-
withObject "ReviewComment" $ \o ->
83-
ReviewComment <$> o .: "body" <*> o .: "url" <*>
84-
o .: "pull_request_review_id" <*>
85-
o .: "diff_hunk" <*>
86-
o .: "path" <*>
87-
o .: "position" <*>
88-
o .: "original_position" <*>
89-
o .: "commit_id" <*>
90-
o .: "original_commit_id" <*>
91-
o .: "created_at" <*>
92-
o .: "updated_at" <*>
93-
o .: "html_url" <*>
94-
o .: "pull_request_url" <*>
95-
o .: "user" <*>
96-
o .: "id"
82+
withObject "ReviewComment" $ \o -> ReviewComment
83+
<$> o .: "id"
84+
<*> o .: "user"
85+
<*> o .: "body"
86+
<*> o .: "url"
87+
<*> o .: "pull_request_review_id"
88+
<*> o .: "diff_hunk"
89+
<*> o .: "path"
90+
<*> o .: "position"
91+
<*> o .: "original_position"
92+
<*> o .: "commit_id"
93+
<*> o .: "original_commit_id"
94+
<*> o .: "created_at"
95+
<*> o .: "updated_at"
96+
<*> o .: "html_url"
97+
<*> o .: "pull_request_url"

0 commit comments

Comments
 (0)