-
Notifications
You must be signed in to change notification settings - Fork 12
Compass sidis #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Compass sidis #2247
Conversation
|
@scarlehoff #2306 will only include SIA datasets, this PR deals with SIDIS. There are a number of changes that need to be made in the SIDIS implementation before it is complete. I plan to do it after #2306. |
|
Ok, perfect! I guess the same is true for #2211 ? |
Yes indeed! Feel free to mark both PRs as draft for the time being if you like. |
|
It's fine, I just wanted to know what was the status since @ggvanseev already graduated |
|
I'll convert it to draft because otherwise I end up clicking it every time to check the status ^^U |
|
It has been prophesized that I will complete this implementation but the era has not been mentioned. xD |
|
btw #2306 has been complete for a long time. you could of course review/approve it if you like 😁 |
This PR implements the COMPASS data for a Deuterium Muon collision to Pion or Kaon (Plus or minus).
Do note that the PR 2211(HERMES_SIDIS) implements the same SIDIS changes, ensure that this PR is updated if PR 2211 is merged first or vice versa.