Update hot water end uses for operational calculations#1761
Merged
Conversation
…e now directly use equations from the FSEC paper that are a function of number of occupants.
Contributor
Author
|
This is ready for testing by @jmaguire1. |
…o hot_water_operational_calc # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hpxml_defaults.rb
jmaguire1
reviewed
Jul 10, 2024
jmaguire1
left a comment
Collaborator
There was a problem hiding this comment.
This all looks good to me. I'm assuming you'd like to wait until I've looked at the ResStock results later this week before we merge?
Contributor
Author
Thanks @jmaguire1. Yes, there's no rush so I will wait on further testing. |
…o hot_water_operational_calc # Conflicts: # Changelog.md # HPXMLtoOpenStudio/measure.rb # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hotwater_appliances.rb
7 tasks
6 tasks
…o hot_water_operational_calc # Conflicts: # BuildResidentialScheduleFile/measure.xml # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
Contributor
Author
|
ORNL confirmed the results look good for WAP, going to merge if the CI comes back green. If ResStock testing identifies any problems, we can address them in a subsequent PR. |
26 tasks
7 tasks
5 tasks
This was referenced Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
For operational calculations (where
NumberofResidentsis provided), we now directly use equations from the FSEC paper that are a function of number of occupants.Checklist
Not all may apply:
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run