Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ed51e53

Browse files
authored
Remove NCCL>=2.10.3 check (#2000)
as 2.10.3 was released in 2021 April. ref: https://docs.nvidia.com/deeplearning/nccl/archives/nccl_2303/release-notes/rel_2-10-3.html Signed-off-by: Masaki Kozuki <[email protected]>
1 parent 0857d7b commit ed51e53

1 file changed

Lines changed: 9 additions & 23 deletions

File tree

setup.py

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -869,30 +869,16 @@ def check_cudnn_version_and_warn(global_option: str, required_cudnn_version: int
869869
if "--nccl_p2p" in sys.argv:
870870
sys.argv.remove("--nccl_p2p")
871871
raise_if_cuda_home_none("--nccl_p2p")
872-
# Check NCCL version.
873-
_nccl_version_getter = load(
874-
name="_nccl_version_getter",
875-
sources=[
876-
"apex/contrib/csrc/nccl_p2p/nccl_version.cpp",
877-
"apex/contrib/csrc/nccl_p2p/nccl_version_check.cu",
878-
],
879-
)
880-
_available_nccl_version = _nccl_version_getter.get_nccl_version()
881-
if _available_nccl_version >= (2, 10):
882-
ext_modules.append(
883-
CUDAExtension(
884-
name="nccl_p2p_cuda",
885-
sources=[
886-
"apex/contrib/csrc/nccl_p2p/nccl_p2p_cuda.cu",
887-
"apex/contrib/csrc/nccl_p2p/nccl_p2p.cpp",
888-
],
889-
extra_compile_args={"cxx": ["-O3"] + generator_flag},
890-
)
891-
)
892-
else:
893-
warnings.warn(
894-
f"Skip `--nccl_p2p` as it requires NCCL 2.10.3 or later, but {_available_nccl_version[0]}.{_available_nccl_version[1]}"
872+
ext_modules.append(
873+
CUDAExtension(
874+
name="nccl_p2p_cuda",
875+
sources=[
876+
"apex/contrib/csrc/nccl_p2p/nccl_p2p_cuda.cu",
877+
"apex/contrib/csrc/nccl_p2p/nccl_p2p.cpp",
878+
],
879+
extra_compile_args={"cxx": ["-O3"] + generator_flag},
895880
)
881+
)
896882

897883
# note (mkozuki): Now `--fast_bottleneck` option (i.e. apex/contrib/bottleneck) depends on `--peer_memory` and `--nccl_p2p`.
898884
if has_flag("--fast_bottleneck", "APEX_FAST_BOTTLENECK"):

0 commit comments

Comments
 (0)