Fix CI after postprocessing changes#1545
Conversation
| # Because "float nan: <class 'float'>, G15000301: <class 'str'>" leads to | ||
| # TypeError: 'float' object is not an instance of 'str': | ||
| puma_map = {k: v for k, v in puma_map.items() if not isinstance(k, float)} |
There was a problem hiding this comment.
In resources/gisdata/ipums_pums_2010_simple_t100_area_us_puma.geojson, "puma_tsv": null for the item with "GISJOIN": "G15000301" (and "state_abbr": "HI").
There was a problem hiding this comment.
Looks like all the AK's are null, too.
There was a problem hiding this comment.
In c583efb, I'm removing this workaround and manually updating all "puma_tsv": null with "puma_tsv": "<state_abbr>, <PUMA>" in the geojson file.
…kup with missing puma_tsv values.
| if not col_name.startswith("upgrade."): | ||
| continue |
There was a problem hiding this comment.
This "fix" gets rid of the, e.g., "Extra column: build_existing_model.ahs_region", "Extra column: upgrade_costs.option_01_name", etc lines.
But it's still not totally clear to me what this method intends to do. Add upgrade columns to upgrade dataframes and baseline dataframe? Which upgrade columns?
Pull Request Description
Fix failing tests due to #1509.
Companion PR: NatLabRockies/buildstockbatch#520
Related Pull Requests
[related PRs from different repositories]
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run