ext/jaeger - Transform resource to tags when exporting (open-telemetry#645)

nirsky · toumorokoshi · web-flow · commit 01b91170dafd · 2020-05-18T21:28:48.000-07:00
Labels in the resource now populate span tags for the Jaeger exporter.

Co-authored-by: Yusuke Tsutsumi &lt;yusuke@tsutsumi.io&gt;
diff --git a/ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py b/ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py
@@ -197,6 +197,8 @@ def _translate_to_jaeger(spans: Span):
         parent_id = span.parent.span_id if span.parent else 0
 
         tags = _extract_tags(span.attributes)
+        if span.resource:
+            tags.extend(_extract_tags(span.resource.labels))
 
         tags.extend(
             [
diff --git a/ext/opentelemetry-ext-jaeger/tests/test_jaeger_exporter.py b/ext/opentelemetry-ext-jaeger/tests/test_jaeger_exporter.py
@@ -22,6 +22,7 @@
 from opentelemetry import trace as trace_api
 from opentelemetry.ext.jaeger.gen.jaeger import ttypes as jaeger
 from opentelemetry.sdk import trace
+from opentelemetry.sdk.trace import Resource
 from opentelemetry.trace.status import Status, StatusCanonicalCode
 
 
@@ -199,6 +200,9 @@ def test_translate_to_jaeger(self):
         otel_spans[0].set_attribute("key_bool", False)
         otel_spans[0].set_attribute("key_string", "hello_world")
         otel_spans[0].set_attribute("key_float", 111.22)
+        otel_spans[0].resource = Resource(
+            labels={"key_resource": "some_resource"}
+        )
         otel_spans[0].set_status(
             Status(StatusCanonicalCode.UNKNOWN, "Example description")
         )
@@ -237,6 +241,11 @@ def test_translate_to_jaeger(self):
                         vType=jaeger.TagType.DOUBLE,
                         vDouble=111.22,
                     ),
+                    jaeger.Tag(
+                        key="key_resource",
+                        vType=jaeger.TagType.STRING,
+                        vStr="some_resource",
+                    ),
                     jaeger.Tag(
                         key="status.code",
                         vType=jaeger.TagType.LONG,

Original file line number	Diff line number	Diff line change
`@@ -197,6 +197,8 @@ def _translate_to_jaeger(spans: Span):`
`197`	`197`	`parent_id = span.parent.span_id if span.parent else 0`
`198`	`198`
`199`	`199`	`tags = _extract_tags(span.attributes)`
	`200`	`+ if span.resource:`
	`201`	`+ tags.extend(_extract_tags(span.resource.labels))`
`200`	`202`
`201`	`203`	`tags.extend(`
`202`	`204`	`[`