-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Media query support #10530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NathanWalker
merged 37 commits into
NativeScript:main
from
CatchABus:media-query-support
Jul 1, 2024
Merged
feat(core): Media query support #10530
NathanWalker
merged 37 commits into
NativeScript:main
from
CatchABus:media-query-support
Jul 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe788de
to
5c21bda
Compare
048112b
to
0874a74
Compare
NathanWalker
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Core is missing support for media queries.
What is the new behavior?
CSS media queries, MediaQueryList, and method matchMedia implementation.
To parse the queries, we are porting css-mediaquery to core rewritten in TypeScript. This one is quite old and supports up to Level 3 specs but we can replace it when we find one that's compatible with {N}.
Keyframes rules improvements are also included as they were poorly implemented before.
Supported media features:
Usage
matchMedia
Common media query
Common media query with nested keyframes
Nested media query
Implements/Closes #64 NativeScript/rfcs#46 .
Fixes #6314