ExecutorScheduler to wrap an Executor #1272
Merged
+222
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1170 SUCCESS |
|
Thanks @akarnokd for this. Looks good for a first cut. The trade-offs (thread hopping) are expected, and why we won't use this as a default for anything, and agreed on possible improvements, but those can come later. |
benjchristensen
added a commit
that referenced
this pull request
May 28, 2014
ExecutorScheduler to wrap an Executor
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1219 (and #1206)
This implementation should conform with the Scheduler contract except it is not possible to avoid thread-hopping (don't worry, the tasks execute serially, but maybe not on the same physical thread).
Few open improvement possibilities:
MpscLinkedQueueonce available.CompositeSubscription.Subscriptionfrom aCompositeSubscriptionwithout it calling unsubscribe on the removed Subscription, á laMultipleAssignmentSubscription.set().