Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 0a331b2

Browse files
bradzacherbradzacher
committed
Merge branch 'master' into 3-7-syntax-parsing
2 parents 790c1b0 + 054df27 commit 0a331b2

File tree

16 files changed

+106
-16
lines changed

16 files changed

+106
-16
lines changed

‎CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,19 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
## [2.3.3](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.2...v2.3.3) (2019-10-07)
7+
8+
9+
### Bug Fixes
10+
11+
* **eslint-plugin:** [class-name-casing] allow unicode letters ([#1043](https://github.com/typescript-eslint/typescript-eslint/issues/1043)) ([47895c0](https://github.com/typescript-eslint/typescript-eslint/commit/47895c0))
12+
* **eslint-plugin:** [efrt] support constructor arguments ([#1021](https://github.com/typescript-eslint/typescript-eslint/issues/1021)) ([60943e6](https://github.com/typescript-eslint/typescript-eslint/commit/60943e6))
13+
* **experimental-utils:** remove Rule.meta.extraDescription ([#1036](https://github.com/typescript-eslint/typescript-eslint/issues/1036)) ([192e23d](https://github.com/typescript-eslint/typescript-eslint/commit/192e23d))
14+
15+
16+
17+
18+
619
## [2.3.2](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.1...v2.3.2) (2019-09-30)
720

821

‎lerna.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "2.3.2",
2+
"version": "2.3.3",
33
"npmClient": "yarn",
44
"useWorkspaces": true,
55
"stream": true

‎packages/eslint-plugin-tslint/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
## [2.3.3](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.2...v2.3.3) (2019-10-07)
7+
8+
**Note:** Version bump only for package @typescript-eslint/eslint-plugin-tslint
9+
10+
11+
12+
13+
614
## [2.3.2](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.1...v2.3.2) (2019-09-30)
715

816
**Note:** Version bump only for package @typescript-eslint/eslint-plugin-tslint

‎packages/eslint-plugin-tslint/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@typescript-eslint/eslint-plugin-tslint",
3-
"version": "2.3.2",
3+
"version": "2.3.3",
44
"main": "dist/index.js",
55
"typings": "src/index.ts",
66
"description": "TSLint wrapper plugin for ESLint",
@@ -31,7 +31,7 @@
3131
"typecheck": "tsc --noEmit"
3232
},
3333
"dependencies": {
34-
"@typescript-eslint/experimental-utils": "2.3.2",
34+
"@typescript-eslint/experimental-utils": "2.3.3",
3535
"lodash.memoize": "^4.1.2"
3636
},
3737
"peerDependencies": {
@@ -41,6 +41,6 @@
4141
},
4242
"devDependencies": {
4343
"@types/lodash.memoize": "^4.1.4",
44-
"@typescript-eslint/parser": "2.3.2"
44+
"@typescript-eslint/parser": "2.3.3"
4545
}
4646
}

‎packages/eslint-plugin/CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,18 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
## [2.3.3](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.2...v2.3.3) (2019-10-07)
7+
8+
9+
### Bug Fixes
10+
11+
* **eslint-plugin:** [class-name-casing] allow unicode letters ([#1043](https://github.com/typescript-eslint/typescript-eslint/issues/1043)) ([47895c0](https://github.com/typescript-eslint/typescript-eslint/commit/47895c0))
12+
* **eslint-plugin:** [efrt] support constructor arguments ([#1021](https://github.com/typescript-eslint/typescript-eslint/issues/1021)) ([60943e6](https://github.com/typescript-eslint/typescript-eslint/commit/60943e6))
13+
14+
15+
16+
17+
618
## [2.3.2](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.1...v2.3.2) (2019-09-30)
719

820

‎packages/eslint-plugin/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@typescript-eslint/eslint-plugin",
3-
"version": "2.3.2",
3+
"version": "2.3.3",
44
"description": "TypeScript plugin for ESLint",
55
"keywords": [
66
"eslint",
@@ -40,7 +40,7 @@
4040
"typecheck": "tsc --noEmit"
4141
},
4242
"dependencies": {
43-
"@typescript-eslint/experimental-utils": "2.3.2",
43+
"@typescript-eslint/experimental-utils": "2.3.3",
4444
"eslint-utils": "^1.4.2",
4545
"functional-red-black-tree": "^1.0.1",
4646
"regexpp": "^2.0.1",

‎packages/eslint-plugin/src/rules/explicit-function-return-type.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,15 @@ export default util.createRule<Options, MessageIds>({
152152
);
153153
}
154154

155+
/**
156+
* Checks if a node belongs to:
157+
* new Foo(() => {})
158+
* ^^^^^^^^
159+
*/
160+
function isConstructorArgument(parent: TSESTree.Node): boolean {
161+
return parent.type === AST_NODE_TYPES.NewExpression;
162+
}
163+
155164
/**
156165
* Checks if a node is a type cast
157166
* `(() => {}) as Foo`
@@ -325,7 +334,8 @@ export default util.createRule<Options, MessageIds>({
325334
isVariableDeclaratorWithTypeAnnotation(node.parent) ||
326335
isClassPropertyWithTypeAnnotation(node.parent) ||
327336
isPropertyOfObjectWithType(node.parent) ||
328-
isFunctionArgument(node.parent, node)
337+
isFunctionArgument(node.parent, node) ||
338+
isConstructorArgument(node.parent)
329339
) {
330340
return;
331341
}

‎packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,18 @@ const func = (value: number) => x as const;
322322
},
323323
],
324324
},
325+
{
326+
filename: 'test.ts',
327+
code: `
328+
new Promise(resolve => {});
329+
new Foo(1, () => {});
330+
`,
331+
options: [
332+
{
333+
allowTypedFunctionExpressions: true,
334+
},
335+
],
336+
},
325337
],
326338
invalid: [
327339
{

‎packages/experimental-utils/CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,17 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
## [2.3.3](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.2...v2.3.3) (2019-10-07)
7+
8+
9+
### Bug Fixes
10+
11+
* **experimental-utils:** remove Rule.meta.extraDescription ([#1036](https://github.com/typescript-eslint/typescript-eslint/issues/1036)) ([192e23d](https://github.com/typescript-eslint/typescript-eslint/commit/192e23d))
12+
13+
14+
15+
16+
617
## [2.3.2](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.1...v2.3.2) (2019-09-30)
718

819
**Note:** Version bump only for package @typescript-eslint/experimental-utils

‎packages/experimental-utils/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@typescript-eslint/experimental-utils",
3-
"version": "2.3.2",
3+
"version": "2.3.3",
44
"description": "(Experimental) Utilities for working with TypeScript + ESLint together",
55
"keywords": [
66
"eslint",
@@ -37,7 +37,7 @@
3737
},
3838
"dependencies": {
3939
"@types/json-schema": "^7.0.3",
40-
"@typescript-eslint/typescript-estree": "2.3.2",
40+
"@typescript-eslint/typescript-estree": "2.3.3",
4141
"eslint-scope": "^5.0.0"
4242
},
4343
"peerDependencies": {

‎packages/parser/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
## [2.3.3](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.2...v2.3.3) (2019-10-07)
7+
8+
**Note:** Version bump only for package @typescript-eslint/parser
9+
10+
11+
12+
13+
614
## [2.3.2](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.1...v2.3.2) (2019-09-30)
715

816

‎packages/parser/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@typescript-eslint/parser",
3-
"version": "2.3.2",
3+
"version": "2.3.3",
44
"description": "An ESLint custom parser which leverages TypeScript ESTree",
55
"main": "dist/parser.js",
66
"types": "dist/parser.d.ts",
@@ -43,13 +43,13 @@
4343
},
4444
"dependencies": {
4545
"@types/eslint-visitor-keys": "^1.0.0",
46-
"@typescript-eslint/experimental-utils": "2.3.2",
47-
"@typescript-eslint/typescript-estree": "2.3.2",
46+
"@typescript-eslint/experimental-utils": "2.3.3",
47+
"@typescript-eslint/typescript-estree": "2.3.3",
4848
"eslint-visitor-keys": "^1.1.0"
4949
},
5050
"devDependencies": {
5151
"@types/glob": "^7.1.1",
52-
"@typescript-eslint/shared-fixtures": "2.3.2",
52+
"@typescript-eslint/shared-fixtures": "2.3.3",
5353
"glob": "^7.1.4"
5454
}
5555
}

‎packages/shared-fixtures/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
## [2.3.3](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.2...v2.3.3) (2019-10-07)
7+
8+
**Note:** Version bump only for package @typescript-eslint/shared-fixtures
9+
10+
11+
12+
13+
614
## [2.3.2](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.1...v2.3.2) (2019-09-30)
715

816

‎packages/shared-fixtures/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"name": "@typescript-eslint/shared-fixtures",
3-
"version": "2.3.2",
3+
"version": "2.3.3",
44
"private": true
55
}

‎packages/typescript-estree/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
## [2.3.3](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.2...v2.3.3) (2019-10-07)
7+
8+
**Note:** Version bump only for package @typescript-eslint/typescript-estree
9+
10+
11+
12+
13+
614
## [2.3.2](https://github.com/typescript-eslint/typescript-eslint/compare/v2.3.1...v2.3.2) (2019-09-30)
715

816

‎packages/typescript-estree/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@typescript-eslint/typescript-estree",
3-
"version": "2.3.2",
3+
"version": "2.3.3",
44
"description": "A parser that converts TypeScript source code into an ESTree compatible form",
55
"main": "dist/parser.js",
66
"types": "dist/parser.d.ts",
@@ -56,7 +56,7 @@
5656
"@types/lodash.isplainobject": "^4.0.4",
5757
"@types/lodash.unescape": "^4.0.4",
5858
"@types/semver": "^6.0.1",
59-
"@typescript-eslint/shared-fixtures": "2.3.2",
59+
"@typescript-eslint/shared-fixtures": "2.3.3",
6060
"babel-code-frame": "^6.26.0",
6161
"glob": "^7.1.4",
6262
"lodash.isplainobject": "4.0.6",

0 commit comments

Comments
 (0)