fix: nullish coalescing should be logical expression, not binary

bradzacher · bradzacher · commit ff86547e51d2 · 2019-10-07T18:31:17.000-07:00
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -1676,7 +1676,7 @@ export class Converter {
             | TSESTree.LogicalExpression
             | TSESTree.BinaryExpression
           >(node, {
-            type: type,
+            type,
             operator: getTextForTokenKind(node.operatorToken.kind)!,
             left: this.converter(
               node.left,
diff --git a/packages/typescript-estree/src/node-utils.ts b/packages/typescript-estree/src/node-utils.ts
@@ -20,9 +20,12 @@ const ASSIGNMENT_OPERATORS: ts.AssignmentOperator[] = [
   SyntaxKind.CaretEqualsToken,
 ];
 
-const LOGICAL_OPERATORS: ts.LogicalOperator[] = [
+const LOGICAL_OPERATORS: (
+  | ts.LogicalOperator
+  | ts.SyntaxKind.QuestionQuestionToken)[] = [
   SyntaxKind.BarBarToken,
   SyntaxKind.AmpersandAmpersandToken,
+  SyntaxKind.QuestionQuestionToken,
 ];
 
 const TOKEN_TO_TEXT: { readonly [P in ts.SyntaxKind]?: string } = {
diff --git a/packages/typescript-estree/tests/lib/__snapshots__/typescript.ts.snap b/packages/typescript-estree/tests/lib/__snapshots__/typescript.ts.snap
@@ -65452,7 +65452,7 @@ Object {
                       "type": "Literal",
                       "value": "",
                     },
-                    "type": "BinaryExpression",
+                    "type": "LogicalExpression",
                   },
                   "optional": false,
                   "property": Object {
@@ -65621,7 +65621,7 @@ Object {
                         "type": "Literal",
                         "value": "",
                       },
-                      "type": "BinaryExpression",
+                      "type": "LogicalExpression",
                     },
                     "optional": false,
                     "property": Object {
