Thanks to visit codestin.com
Credit goes to github.com

Skip to content

manage CCRAM section #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 31, 2021
Merged

manage CCRAM section #165

merged 13 commits into from
Jan 31, 2021

Conversation

@atsju
Copy link
Collaborator

@atsju atsju commented Dec 14, 2020 •
edited
Loading

Change CCRAM management to be like explained in #164

  • F0 - reviewed
  • F1 - reviewed
  • F2 - reviewed
  • F3 - commited correction
  • F4 - commited correction
  • F7 - reviewed
  • G0 - reviewed and added future devices
  • G4 - commited correction and added new/future device support
  • H7 - commited correction and added new/future device support
  • L0 - reviewed
  • L1 - reviewed and minor refactor
  • L4 - commited correction

closes #164

Hish15
Hish15 reviewed Dec 19, 2020
View reviewed changes
@Hish15
Copy link
Collaborator

Hish15 commented Dec 19, 2020

I tried to better align things up, check if its rendering fine

atsju and others added 2 commits December 19, 2020 11:22
@Hish15
Copy link
Collaborator

Hish15 commented Dec 19, 2020 •
edited
Loading

Rechecked Families By me :

  • G0
  • L4

@Hish15
Copy link
Collaborator

Hish15 commented Dec 19, 2020

Maybe we can change the order of the device to follow ST families e.g :
L4 : L4x1, L4x2, L4x3, L4x5, L4x6 ?

@atsju
Copy link
Collaborator Author

atsju commented Dec 19, 2020 •
edited
Loading

Maybe we can change the order of the device to follow ST families e.g :
L4 : L4x1, L4x2, L4x3, L4x5, L4x6 ?

Good idea. Maybe add this remark to #169 or create a new ticket/PR.

@Hish15 Hish15 mentioned this pull request Dec 19, 2020
Closed
@atsju atsju mentioned this pull request Dec 19, 2020
Closed
@ObKo
Copy link
Owner

ObKo commented Dec 20, 2020

Is this ready for merging?

@atsju
Copy link
Collaborator Author

atsju commented Dec 20, 2020

Is this ready for merging?

@ObKo It is on my side. Maybe @Hish15 want's to finish his review ?

@Hish15
Copy link
Collaborator

Hish15 commented Dec 20, 2020

@ObKo, I'm currently having a look .
#165 (comment)
Thumbs up to @atsju, it is a long process to get all the data needed here.

Hish15
Hish15 reviewed Dec 20, 2020
View reviewed changes
Hish15
Hish15 reviewed Dec 20, 2020
View reviewed changes
@Hish15
Copy link
Collaborator

Hish15 commented Dec 20, 2020

Th F3 family is a complete mess datasheet wise. I will use STM32CubeF3\Drivers\CMSIS\Device\ST\STM32F3xx\Source\Templates\iar\linker\st as described in #171

@atsju
Copy link
Collaborator Author

atsju commented Dec 20, 2020

Th F3 family is a complete mess datasheet wise. I will use STM32CubeF3\Drivers\CMSIS\Device\ST\STM32F3xx\Source\Templates\iar\linker\st as described in #171

Feel my pain 😁

Hish15
Hish15 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@Hish15 Hish15 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ObKo, All good to me.

@Danaozhong
Copy link

Danaozhong commented Dec 31, 2020

Looks good!
I tested this on a STM32F303CCT6 chip. Without the change, it would immediately enter the hard fault handler, with this change it starts up normally and runs stable. At least for this chip, the RAM configuration looks good to me,

@ObKo ObKo merged commit 2f504e1 into ObKo:master Jan 31, 2021
@atsju atsju mentioned this pull request May 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hish15 Hish15 Hish15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CCRAM handling

4 participants

@atsju @Hish15 @ObKo @Danaozhong