Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated size command #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 24, 2021
Merged

Updated size command #207

merged 6 commits into from
Jun 24, 2021

Conversation

@robamu
Copy link
Contributor

@robamu robamu commented Jun 8, 2021 •
edited
Loading

Merge after #182 , extends it with more modern CMake syntax with all lower-case letters

@robamu robamu mentioned this pull request Jun 8, 2021
Merged
@atsju atsju self-requested a review June 23, 2021 06:18
atsju
atsju requested changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@atsju atsju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rmspacefish
Please note #182 has been merged.
If I'm correct your commit will print size but only as post build step. If you rebuild and there is "nothing to do" then you do not print size again. The original solution will always print size even when there is nothing to do. For people developping in an IDE where the command line is erased when you hit compile it can be useful to not lose the information.

@atsju atsju requested a review from Hish15 June 23, 2021 07:27
@robamu
Copy link
Contributor Author

robamu commented Jun 23, 2021

I' m getting weird errors right now, not sure if it is related. need to check this..

@robamu
Copy link
Contributor Author

robamu commented Jun 23, 2021 •
edited
Loading

Hmm this is odd. I'm getting this error right now when building the freertos example

r:~/Software/STM32/stm32h743-cmake-minimal/stm32-cmake/examples/freertos/build$ cmake --build . -j
gmake[2]: *** No rule to make target 'stm32-freertos.elf', needed by 'CMakeFiles/stm32-freertos_size'.  Stop.
gmake[1]: *** [CMakeFiles/Makefile2:86: CMakeFiles/stm32-freertos_size.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
[  6%] Built target CMSIS_LD_F407VG
gmake: *** [Makefile:91: all] Error 2

@atsju
Copy link
Collaborator

atsju commented Jun 23, 2021

@Hish15 we need to do a CI with the actions as required with support of Obko.

@robamu
Copy link
Contributor Author

robamu commented Jun 23, 2021 •
edited
Loading

Alright, I had to omit the ${CMAKE_EXECUTABLE_SUFFIX_C} in DEPENDS so that the example builds for me.. The target ${TARGET}${CMAKE_EXECUTABLE_SUFFIX_C} does not seem to exists for CMake. Could you test whether this solution works for you as well? That would be great

atsju
atsju requested changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@atsju atsju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with DEPENDS ${TARGET} and with DEPENDS ${TARGET}${CMAKE_EXECUTABLE_SUFFIX_C}

Both are working on blinky example. I didn't push investigation further

@Hish15 Hish15 merged commit 52205c6 into ObKo:master Jun 24, 2021
@robamu robamu deleted the mueller/updated-size-command branch July 12, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atsju atsju atsju approved these changes

@Hish15 Hish15 Hish15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robamu @atsju @Hish15