Toolchain file update #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use STM32_TOOLCHAIN_PATH if specified as environmental variable 2. Find tools like objcopy and size in default paths as well, which allows simply adding the binary folder of the toolchain to the path to find them. This also allows more consistent behaviour, because this already works for <cross-compile>-gcc/g++
Collaborator
Contributor
Author
|
Ok. Maybe we can merge it first? It looks finished, but I have not read everything yet |
Collaborator
|
I'm at work now. But looks fine, I will test ASAP and it can be merged regardless of other PR. As I said it was only for information. |
Hish15
requested changes
Jul 15, 2021
Collaborator
Hish15
left a comment
There was a problem hiding this comment.
Here setting STM32_TOOLCHAIN_PATH in a env var, will make setting the value directly impossible. I think we want to check if the var is not set (using CLI or in the cmakelist) before using ENV var.
atsju
reviewed
Jul 15, 2021
Co-authored-by: Julien Staub <[email protected]>
atsju
approved these changes
Jul 15, 2021
Hish15
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STM32_TOOLCHAIN_PATHfrom environment if specified as environmental variablesimply adding the binary folder of the toolchain to the path to find them.
This also allows more consistent behaviour, because this already works
for -gcc/g++
closes #216