Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add missing target for H7 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2021
Merged

Add missing target for H7 #255

merged 3 commits into from
Aug 3, 2021

Conversation

@zisi
Copy link
Contributor

@zisi zisi commented Aug 2, 2021

When in H7 want to use HCD HAL::STM32::H7::M7::HCD, it returns error

CMake Error at test/CMakeLists.txt:1 (add_executable):
  Target "test" links to target "HAL::STM32::H7::M7::HCD" but the target was                                                                                                                   
  not found.  Perhaps a find_package() call is missing for an IMPORTED                                                                                                                         
  target, or an ALIAS target is missing?

Signed-off-by: Agis Zisimatos [email protected]

atsju
atsju requested changes Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@atsju atsju left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request. I think you spotted an evolution of the HAL.
could you please have a look at whole HAL and add all missing modules (cordic, fmac, ...)

@zisi zisi force-pushed the missing-hal-module branch 3 times, most recently from 0ea259a to 5cf26c4 Compare August 3, 2021 11:14
@zisi
Add missing target for H7
3af8191 
Signed-off-by: Agis Zisimatos <[email protected]>
@zisi zisi force-pushed the missing-hal-module branch from 5cf26c4 to 3af8191 Compare August 3, 2021 11:17
@zisi zisi changed the title Add missing target for H7 (HCD) Add missing target for H7 Aug 3, 2021
@zisi
Copy link
Contributor Author

zisi commented Aug 3, 2021

I think, i have added all missing modules.

atsju
atsju requested changes Aug 3, 2021
View reviewed changes
@atsju atsju self-requested a review August 3, 2021 11:37
@atsju atsju requested a review from Hish15 August 3, 2021 11:37
atsju
atsju approved these changes Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@atsju atsju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed one. I have added it.
Thank you.

atsju
atsju approved these changes Aug 3, 2021
View reviewed changes
@Hish15 Hish15 merged commit 8f4c311 into ObKo:master Aug 3, 2021
@atsju atsju mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atsju atsju atsju approved these changes

@Hish15 Hish15 Hish15 approved these changes

Assignees

@Hish15 Hish15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zisi @atsju @Hish15