Fix chooseSwapPresentMode not passing by const reference

Overv · Overv · commit 170ce5944308 · 2019-03-17T14:55:24.000+01:00
diff --git a/03_Drawing_a_triangle/01_Presentation/01_Swap_chain.md b/03_Drawing_a_triangle/01_Presentation/01_Swap_chain.md
@@ -302,7 +302,7 @@ Only the `VK_PRESENT_MODE_FIFO_KHR` mode is guaranteed to be available, so we'll
 again have to write a function that looks for the best mode that is available:
 
 ```c++
-VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
     return VK_PRESENT_MODE_FIFO_KHR;
 }
 ```
@@ -313,7 +313,7 @@ images that are as up-to-date as possible right until the vertical blank. So,
 let's look through the list to see if it's available:
 
 ```c++
-VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
     for (const auto& availablePresentMode : availablePresentModes) {
         if (availablePresentMode == VK_PRESENT_MODE_MAILBOX_KHR) {
             return availablePresentMode;
@@ -329,7 +329,7 @@ Unfortunately some drivers currently don't properly support
 if `VK_PRESENT_MODE_MAILBOX_KHR` is not available:
 
 ```c++
-VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
     VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
     for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/06_swap_chain_creation.cpp b/code/06_swap_chain_creation.cpp
@@ -312,7 +312,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/07_image_views.cpp b/code/07_image_views.cpp
@@ -343,7 +343,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/08_graphics_pipeline.cpp b/code/08_graphics_pipeline.cpp
@@ -348,7 +348,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/09_shader_modules.cpp b/code/09_shader_modules.cpp
@@ -384,7 +384,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/10_fixed_functions.cpp b/code/10_fixed_functions.cpp
@@ -456,7 +456,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/11_render_passes.cpp b/code/11_render_passes.cpp
@@ -491,7 +491,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/12_graphics_pipeline_complete.cpp b/code/12_graphics_pipeline_complete.cpp
@@ -512,7 +512,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/13_framebuffers.cpp b/code/13_framebuffers.cpp
@@ -541,7 +541,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/14_command_buffers.cpp b/code/14_command_buffers.cpp
@@ -607,7 +607,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/15_hello_triangle.cpp b/code/15_hello_triangle.cpp
@@ -699,7 +699,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/16_swap_chain_recreation.cpp b/code/16_swap_chain_recreation.cpp
@@ -746,7 +746,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/17_vertex_input.cpp b/code/17_vertex_input.cpp
@@ -791,7 +791,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/18_vertex_buffer.cpp b/code/18_vertex_buffer.cpp
@@ -847,7 +847,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/19_staging_buffer.cpp b/code/19_staging_buffer.cpp
@@ -895,7 +895,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/20_index_buffer.cpp b/code/20_index_buffer.cpp
@@ -928,7 +928,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/21_descriptor_layout.cpp b/code/21_descriptor_layout.cpp
@@ -999,7 +999,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/22_descriptor_sets.cpp b/code/22_descriptor_sets.cpp
@@ -1056,7 +1056,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/23_texture_image.cpp b/code/23_texture_image.cpp
@@ -1211,7 +1211,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/24_sampler.cpp b/code/24_sampler.cpp
@@ -1247,7 +1247,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/25_texture_mapping.cpp b/code/25_texture_mapping.cpp
@@ -1277,7 +1277,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/26_depth_buffering.cpp b/code/26_depth_buffering.cpp
@@ -1375,7 +1375,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/27_model_loading.cpp b/code/27_model_loading.cpp
@@ -1421,7 +1421,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/28_mipmapping.cpp b/code/28_mipmapping.cpp
@@ -1515,7 +1515,7 @@ class HelloTriangleApplication {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {
diff --git a/code/29_multisampling.cpp b/code/29_multisampling.cpp
@@ -1574,7 +1574,7 @@ VkSampleCountFlagBits getMaxUsableSampleCount() {
         return availableFormats[0];
     }
 
-    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {
+    VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {
         VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;
 
         for (const auto& availablePresentMode : availablePresentModes) {

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ class HelloTriangleApplication {`
`312`	`312`	`return availableFormats[0];`
`313`	`313`	`}`
`314`	`314`
`315`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`315`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`316`	`316`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`317`	`317`
`318`	`318`	`for (const auto& availablePresentMode : availablePresentModes) {`
Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,7 @@ class HelloTriangleApplication {`
`343`	`343`	`return availableFormats[0];`
`344`	`344`	`}`
`345`	`345`
`346`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`346`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`347`	`347`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`348`	`348`
`349`	`349`	`for (const auto& availablePresentMode : availablePresentModes) {`
Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,7 @@ class HelloTriangleApplication {`
`348`	`348`	`return availableFormats[0];`
`349`	`349`	`}`
`350`	`350`
`351`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`351`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`352`	`352`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`353`	`353`
`354`	`354`	`for (const auto& availablePresentMode : availablePresentModes) {`
Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ class HelloTriangleApplication {`
`384`	`384`	`return availableFormats[0];`
`385`	`385`	`}`
`386`	`386`
`387`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`387`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`388`	`388`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`389`	`389`
`390`	`390`	`for (const auto& availablePresentMode : availablePresentModes) {`
Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ class HelloTriangleApplication {`
`456`	`456`	`return availableFormats[0];`
`457`	`457`	`}`
`458`	`458`
`459`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`459`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`460`	`460`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`461`	`461`
`462`	`462`	`for (const auto& availablePresentMode : availablePresentModes) {`
Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ class HelloTriangleApplication {`
`491`	`491`	`return availableFormats[0];`
`492`	`492`	`}`
`493`	`493`
`494`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`494`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`495`	`495`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`496`	`496`
`497`	`497`	`for (const auto& availablePresentMode : availablePresentModes) {`
Original file line number	Diff line number	Diff line change
`@@ -512,7 +512,7 @@ class HelloTriangleApplication {`
`512`	`512`	`return availableFormats[0];`
`513`	`513`	`}`
`514`	`514`
`515`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`515`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`516`	`516`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`517`	`517`
`518`	`518`	`for (const auto& availablePresentMode : availablePresentModes) {`
Original file line number	Diff line number	Diff line change
`@@ -541,7 +541,7 @@ class HelloTriangleApplication {`
`541`	`541`	`return availableFormats[0];`
`542`	`542`	`}`
`543`	`543`
`544`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`544`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`545`	`545`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`546`	`546`
`547`	`547`	`for (const auto& availablePresentMode : availablePresentModes) {`
Original file line number	Diff line number	Diff line change
`@@ -607,7 +607,7 @@ class HelloTriangleApplication {`
`607`	`607`	`return availableFormats[0];`
`608`	`608`	`}`
`609`	`609`
`610`		`- VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR> availablePresentModes) {`
	`610`	`+ VkPresentModeKHR chooseSwapPresentMode(const std::vector<VkPresentModeKHR>& availablePresentModes) {`
`611`	`611`	`VkPresentModeKHR bestMode = VK_PRESENT_MODE_FIFO_KHR;`
`612`	`612`
`613`	`613`	`for (const auto& availablePresentMode : availablePresentModes) {`