Fix application crashing when minimizing the window

Overv · Overv · commit 4be0406b1a8e · 2016-07-28T16:34:16.000+02:00
diff --git a/03_Drawing_a_triangle/04_Swap_chain_recreation.md b/03_Drawing_a_triangle/04_Swap_chain_recreation.md
@@ -112,6 +112,8 @@ void initWindow() {
 ...
 
 static void onWindowResized(GLFWwindow* window, int width, int height) {
+    if (width == 0 || height == 0) return;
+
     HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
     app->recreateSwapChain();
 }
@@ -123,7 +125,9 @@ argument, so we can't directly use a member function. Luckily GLFW allows us to
 store an arbitrary pointer in the window object with `glfwSetWindowUserPointer`,
 so we can specify a static class member and get the original class instance back
 with `glfwGetWindowUserPointer`. We can then proceed to call
-`recreateSwapChain`.
+`recreateSwapChain`, but only if the size of the window is non-zero. This case
+occurs when the window is minimized and it will cause swap chain creation to
+fail.
 
 ## Suboptimal or out-of-date swap chain
 
diff --git a/code/depth_buffering.cpp b/code/depth_buffering.cpp
@@ -283,6 +283,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/descriptor_layout.cpp b/code/descriptor_layout.cpp
@@ -249,6 +249,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/descriptor_set.cpp b/code/descriptor_set.cpp
@@ -254,6 +254,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/index_buffer.cpp b/code/index_buffer.cpp
@@ -230,6 +230,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/model_loading.cpp b/code/model_loading.cpp
@@ -289,6 +289,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/sampler.cpp b/code/sampler.cpp
@@ -265,6 +265,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/staging_buffer.cpp b/code/staging_buffer.cpp
@@ -222,6 +222,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/swap_chain_recreation.cpp b/code/swap_chain_recreation.cpp
@@ -178,6 +178,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/texture_image.cpp b/code/texture_image.cpp
@@ -261,6 +261,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/texture_mapping.cpp b/code/texture_mapping.cpp
@@ -271,6 +271,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/vertex_buffer.cpp b/code/vertex_buffer.cpp
@@ -222,6 +222,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }
diff --git a/code/vertex_input.cpp b/code/vertex_input.cpp
@@ -217,6 +217,8 @@ class HelloTriangleApplication {
     }
 
     static void onWindowResized(GLFWwindow* window, int width, int height) {
+        if (width == 0 || height == 0) return;
+        
         HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));
         app->recreateSwapChain();
     }

Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,8 @@ class HelloTriangleApplication {`
`283`	`283`	`}`
`284`	`284`
`285`	`285`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`286`	`+ if (width == 0 \|\| height == 0) return;`
	`287`	`+`
`286`	`288`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`287`	`289`	`app->recreateSwapChain();`
`288`	`290`	`}`
Original file line number	Diff line number	Diff line change
`@@ -249,6 +249,8 @@ class HelloTriangleApplication {`
`249`	`249`	`}`
`250`	`250`
`251`	`251`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`252`	`+ if (width == 0 \|\| height == 0) return;`
	`253`	`+`
`252`	`254`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`253`	`255`	`app->recreateSwapChain();`
`254`	`256`	`}`
Original file line number	Diff line number	Diff line change
`@@ -254,6 +254,8 @@ class HelloTriangleApplication {`
`254`	`254`	`}`
`255`	`255`
`256`	`256`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`257`	`+ if (width == 0 \|\| height == 0) return;`
	`258`	`+`
`257`	`259`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`258`	`260`	`app->recreateSwapChain();`
`259`	`261`	`}`
Original file line number	Diff line number	Diff line change
`@@ -230,6 +230,8 @@ class HelloTriangleApplication {`
`230`	`230`	`}`
`231`	`231`
`232`	`232`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`233`	`+ if (width == 0 \|\| height == 0) return;`
	`234`	`+`
`233`	`235`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`234`	`236`	`app->recreateSwapChain();`
`235`	`237`	`}`
Original file line number	Diff line number	Diff line change
`@@ -289,6 +289,8 @@ class HelloTriangleApplication {`
`289`	`289`	`}`
`290`	`290`
`291`	`291`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`292`	`+ if (width == 0 \|\| height == 0) return;`
	`293`	`+`
`292`	`294`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`293`	`295`	`app->recreateSwapChain();`
`294`	`296`	`}`
Original file line number	Diff line number	Diff line change
`@@ -265,6 +265,8 @@ class HelloTriangleApplication {`
`265`	`265`	`}`
`266`	`266`
`267`	`267`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`268`	`+ if (width == 0 \|\| height == 0) return;`
	`269`	`+`
`268`	`270`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`269`	`271`	`app->recreateSwapChain();`
`270`	`272`	`}`
Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,8 @@ class HelloTriangleApplication {`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`225`	`+ if (width == 0 \|\| height == 0) return;`
	`226`	`+`
`225`	`227`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`226`	`228`	`app->recreateSwapChain();`
`227`	`229`	`}`
Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,8 @@ class HelloTriangleApplication {`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`181`	`+ if (width == 0 \|\| height == 0) return;`
	`182`	`+`
`181`	`183`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`182`	`184`	`app->recreateSwapChain();`
`183`	`185`	`}`
Original file line number	Diff line number	Diff line change
`@@ -261,6 +261,8 @@ class HelloTriangleApplication {`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`static void onWindowResized(GLFWwindow* window, int width, int height) {`
	`264`	`+ if (width == 0 \|\| height == 0) return;`
	`265`	`+`
`264`	`266`	`HelloTriangleApplication* app = reinterpret_cast<HelloTriangleApplication*>(glfwGetWindowUserPointer(window));`
`265`	`267`	`app->recreateSwapChain();`
`266`	`268`	`}`