Add check to readFile function

Overv · Overv · commit 7b5782a46062 · 2016-07-19T00:33:01.000+02:00
diff --git a/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.md b/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.md
@@ -291,6 +291,10 @@ write a simple helper function to load the binary data from the files.
 
 static std::vector<char> readFile(const std::string& filename) {
     std::ifstream file(filename, std::ios::ate | std::ios::binary);
+
+    if (!file.is_open()) {
+        throw std::runtime_error("failed to open file!");
+    }
 }
 ```
 
diff --git a/code/command_buffers.cpp b/code/command_buffers.cpp
@@ -771,6 +771,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/depth_buffering.cpp b/code/depth_buffering.cpp
@@ -1454,6 +1454,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/descriptor_layout.cpp b/code/descriptor_layout.cpp
@@ -1110,6 +1110,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/descriptor_set.cpp b/code/descriptor_set.cpp
@@ -1162,6 +1162,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/fixed_functions.cpp b/code/fixed_functions.cpp
@@ -632,6 +632,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/framebuffers.cpp b/code/framebuffers.cpp
@@ -709,6 +709,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/graphics_pipeline_complete.cpp b/code/graphics_pipeline_complete.cpp
@@ -685,6 +685,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/hello_triangle.cpp b/code/hello_triangle.cpp
@@ -838,6 +838,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/index_buffer.cpp b/code/index_buffer.cpp
@@ -1045,6 +1045,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/model_loading.cpp b/code/model_loading.cpp
@@ -1497,6 +1497,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/render_passes.cpp b/code/render_passes.cpp
@@ -665,6 +665,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/sampler.cpp b/code/sampler.cpp
@@ -1341,6 +1341,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/shader_modules.cpp b/code/shader_modules.cpp
@@ -560,6 +560,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/staging_buffer.cpp b/code/staging_buffer.cpp
@@ -1018,6 +1018,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/swap_chain_recreation.cpp b/code/swap_chain_recreation.cpp
@@ -877,6 +877,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/texture_image.cpp b/code/texture_image.cpp
@@ -1312,6 +1312,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/texture_mapping.cpp b/code/texture_mapping.cpp
@@ -1371,6 +1371,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/vertex_buffer.cpp b/code/vertex_buffer.cpp
@@ -973,6 +973,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 
diff --git a/code/vertex_input.cpp b/code/vertex_input.cpp
@@ -920,6 +920,10 @@ class HelloTriangleApplication {
     static std::vector<char> readFile(const std::string& filename) {
         std::ifstream file(filename, std::ios::ate | std::ios::binary);
 
+        if (!file.is_open()) {
+            throw std::runtime_error("failed to open file!");
+        }
+
         size_t fileSize = (size_t) file.tellg();
         std::vector<char> buffer(fileSize);
 

Original file line number	Diff line number	Diff line change
`@@ -291,6 +291,10 @@ write a simple helper function to load the binary data from the files.`
`291`	`291`
`292`	`292`	`static std::vector<char> readFile(const std::string& filename) {`
`293`	`293`	`std::ifstream file(filename, std::ios::ate \| std::ios::binary);`
	`294`	`+`
	`295`	`+ if (!file.is_open()) {`
	`296`	`+ throw std::runtime_error("failed to open file!");`
	`297`	`+ }`
`294`	`298`	`}`
`295`	`299`	```
`296`	`300`