Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ec0cef1

Browse files
authored
Merge pull request #94 from kondrak/master
Fix "zero-volume area" Vulkan warning when generating mipmaps for odd texture dimensions.
2 parents fd07e81 + 1679c2a commit ec0cef1

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

09_Generating_Mipmaps.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ blit.srcSubresource.mipLevel = i - 1;
158158
blit.srcSubresource.baseArrayLayer = 0;
159159
blit.srcSubresource.layerCount = 1;
160160
blit.dstOffsets[0] = { 0, 0, 0 };
161-
blit.dstOffsets[1] = { mipWidth / 2, mipHeight / 2, 1 };
161+
blit.dstOffsets[1] = { mipWidth > 1 ? mipWidth / 2 : 1, mipHeight > 1 ? mipHeight / 2 : 1, 1 };
162162
blit.dstSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
163163
blit.dstSubresource.mipLevel = i;
164164
blit.dstSubresource.baseArrayLayer = 0;

code/28_mipmapping.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,7 @@ class HelloTriangleApplication {
860860
blit.srcSubresource.baseArrayLayer = 0;
861861
blit.srcSubresource.layerCount = 1;
862862
blit.dstOffsets[0] = {0, 0, 0};
863-
blit.dstOffsets[1] = {mipWidth / 2, mipHeight / 2, 1};
863+
blit.dstOffsets[1] = { mipWidth > 1 ? mipWidth / 2 : 1, mipHeight > 1 ? mipHeight / 2 : 1, 1 };
864864
blit.dstSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
865865
blit.dstSubresource.mipLevel = i;
866866
blit.dstSubresource.baseArrayLayer = 0;

0 commit comments

Comments
 (0)