Thanks to visit codestin.com
Credit goes to github.com

Skip to content

xform inputs from Perl values being made into ndarrays too soon, and thus having a type assigned that requires converting #530

@mohawk2

Description

@mohawk2
  • The XS code part of xforms could be enhanced to analyse the supplied Perl parameters, and use the xform spec to determine the required type for each. It could then make ndarrays out of the Perl values with the required type, avoiding the need for conversion.
  • A further benefit from that would be in generating versions of readdata (backward dataflow wouldn't make sense) that only processed Perl SVs, which would avoid overhead in the Perl-value-only scenario (and allow removing the PMCode for log10).

Other thoughts

  • For generated redodims/readdata/writebackdata functions, they should merge the indx and either long or longlong case, since they are functionally identical and it's a bit less code to generate.
  • non-[o] OtherPars should be copied into stack vars at the start of r/w functions, and be forced as rvalues.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions