minor #2894 NonPrintableCharacterFixer - fix handling required PHP version on PHPUnit 4.x (keradus)

keradus · keradus · commit 4f76ee4f83a6 · 2017-07-02T20:49:30.000+02:00
This PR was merged into the 2.4-dev branch. Discussion ---------- NonPrintableCharacterFixer - fix handling required PHP version on PHPUnit 4.x Commits ------- 0ae03ef NonPrintableCharacterFixer - fix handling required PHP version on PHPUnit 4.x
diff --git a/tests/Fixer/Basic/NonPrintableCharacterFixerTest.php b/tests/Fixer/Basic/NonPrintableCharacterFixerTest.php
@@ -206,6 +206,11 @@ function f(string $p)
      */
     public function testFixWithEscapeSequencesInStringsLowerThanPhp70()
     {
+        // @TODO remove condition after PHPUnit upgrade (and leave annotation)
+        if (PHP_VERSION_ID >= 70000) {
+            $this->markTestSkipped('PHP version to high.');
+        }
+
         $this->setExpectedExceptionRegExp(
             InvalidFixerConfigurationException::class,
             '/^\[non_printable_character\] Invalid configuration: Escape sequences require PHP 7\.0\+\.$/'
diff --git a/tests/Fixer/ClassNotation/VisibilityRequiredFixerTest.php b/tests/Fixer/ClassNotation/VisibilityRequiredFixerTest.php
@@ -451,8 +451,12 @@ public function testInvalidConfigurationValue()
         $this->fixer->configure(['elements' => ['_unknown_']]);
     }
 
+    /**
+     * @requires PHP <7.1
+     */
     public function testInvalidConfigurationValueForPHPVersion()
     {
+        // @TODO remove condition after PHPUnit upgrade (and leave annotation)
         if (PHP_VERSION_ID >= 70100) {
             $this->markTestSkipped('PHP version to high.');
         }

Original file line number	Diff line number	Diff line change
`@@ -451,8 +451,12 @@ public function testInvalidConfigurationValue()`
`451`	`451`	`$this->fixer->configure(['elements' => ['_unknown_']]);`
`452`	`452`	`}`
`453`	`453`
	`454`	`+ /**`
	`455`	`+ * @requires PHP <7.1`
	`456`	`+ */`
`454`	`457`	`public function testInvalidConfigurationValueForPHPVersion()`
`455`	`458`	`{`
	`459`	`+ // @TODO remove condition after PHPUnit upgrade (and leave annotation)`
`456`	`460`	`if (PHP_VERSION_ID >= 70100) {`
`457`	`461`	`$this->markTestSkipped('PHP version to high.');`
`458`	`462`	`}`