ProtectedToPrivateFixer: minor optimization

Slamdunk · Slamdunk · commit 7233e84afabd · 2017-08-22T09:53:14.000+02:00
diff --git a/src/Fixer/ClassNotation/ProtectedToPrivateFixer.php b/src/Fixer/ClassNotation/ProtectedToPrivateFixer.php
@@ -60,7 +60,7 @@ public function getPriority()
      */
     public function isCandidate(Tokens $tokens)
     {
-        return $tokens->isTokenKindFound(T_CLASS);
+        return $tokens->isAllTokenKindsFound([T_CLASS, T_FINAL, T_PROTECTED]);
     }
 
     /**
diff --git a/tests/Fixer/ClassNotation/ProtectedToPrivateFixerTest.php b/tests/Fixer/ClassNotation/ProtectedToPrivateFixerTest.php
@@ -84,6 +84,10 @@ public function provideCases()
                 "<?php final class MyFirstClass { $attributesAndMethodsFixed } class MySecondClass { $attributesAndMethodsOriginal } final class MyThirdClass { $attributesAndMethodsFixed } ",
                 "<?php final class MyFirstClass { $attributesAndMethodsOriginal } class MySecondClass { $attributesAndMethodsOriginal } final class MyThirdClass { $attributesAndMethodsOriginal } ",
             ],
+            'minimal-set' => [
+                '<?php final class MyClass { private $v1; }',
+                '<?php final class MyClass { protected $v1; }',
+            ],
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function getPriority()`
`60`	`60`	`*/`
`61`	`61`	`public function isCandidate(Tokens $tokens)`
`62`	`62`	`{`
`63`		`- return $tokens->isTokenKindFound(T_CLASS);`
	`63`	`+ return $tokens->isAllTokenKindsFound([T_CLASS, T_FINAL, T_PROTECTED]);`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`/**`