feat: Introduce BlankLineAfterStatement fixer#9563
Draft
localheinz wants to merge 4 commits into
Draft
Conversation
localheinz
commented
Apr 15, 2026
Comment on lines
+59
to
+60
| 'if' => \T_IF, | ||
| 'switch' => \T_SWITCH, |
Member
Author
There was a problem hiding this comment.
We could also consider folding the BlankLineAfterNamespaceFixer into this fixer:
Suggested change
| 'if' => \T_IF, | |
| 'switch' => \T_SWITCH, | |
| 'if' => \T_IF, | |
| 'namespace' => \T_NAMESPACE, | |
| 'switch' => \T_SWITCH, |
Contributor
There was a problem hiding this comment.
I would only do this if you also merge the BlankLineBeforeNamespace into the BlankLineBeforeStatement too.
Coverage Report for CI Build 25506351237Coverage decreased (-0.007%) to 93.798%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
localheinz
commented
Apr 15, 2026
Comment on lines
+56
to
+62
| 'do' => \T_DO, | ||
| 'for' => \T_FOR, | ||
| 'foreach' => \T_FOREACH, | ||
| 'if' => \T_IF, | ||
| 'switch' => \T_SWITCH, | ||
| 'try' => \T_TRY, | ||
| 'while' => \T_WHILE, |
Member
Author
There was a problem hiding this comment.
One thing about these (except declare):
- maybe we should also include
match? - are these statements or something else ("blocks")?
- should these be addressed by a different fixer with a more appropriate name?
Contributor
There was a problem hiding this comment.
if switch is included, then imho so should match
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9563 +/- ##
============================================
- Coverage 94.07% 94.06% -0.01%
- Complexity 10860 10905 +45
============================================
Files 583 584 +1
Lines 34171 34325 +154
============================================
+ Hits 32145 32287 +142
- Misses 2026 2038 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmvdbrugge
reviewed
Apr 15, 2026
| /** | ||
| * {@inheritdoc} | ||
| * | ||
| * Must run after NoUselessElseFixer. |
Contributor
dmvdbrugge
reviewed
Apr 15, 2026
|
|
||
| List of statements which must be followed by an empty line. | ||
|
|
||
| Allowed values: a subset of ``['declare', 'do', 'for', 'foreach', 'if', 'switch', 'try', 'while']`` |
Contributor
There was a problem hiding this comment.
the before version also has require(_once) and include(_once), does it make sense to add those too?
dmvdbrugge
reviewed
Apr 15, 2026
| ['statements' => ['try']], | ||
| ]; | ||
|
|
||
| yield 'try-catch-finally - blank line inserted after the end of the whole chain' => [ |
Contributor
There was a problem hiding this comment.
Does it also work with multiple catch blocks?
What about try {} finally {} without catch?
46ac6bc to
b9547bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
BlankLineAfterStatementfixerFollows #9540 (comment).
💁♂️ This is based on existing work, most importantly, @erickskrauch's work on https://github.com/erickskrauch/php-cs-fixer-custom-fixers/blob/1.3.1/src/Fixer/Whitespace/LineBreakAfterStatementsFixer.php.