zulip_bots: Rename SimpleMessageServer to MockMessageServer.

PIG208 · timabbott · commit d949f2024f56 · 2021-05-27T23:52:07.000-07:00
Given that the purpose of this message server is solely for testing,
we rename it for clarity.
diff --git a/zulip_bots/zulip_bots/bots/incrementor/test_incrementor.py b/zulip_bots/zulip_bots/bots/incrementor/test_incrementor.py
@@ -19,7 +19,7 @@ def test_bot(self) -> None:
         bot.initialize(bot_handler)
         bot.handle_message(message, bot_handler)
 
-        with patch('zulip_bots.simple_lib.SimpleMessageServer.update') as m:
+        with patch('zulip_bots.simple_lib.MockMessageServer.update') as m:
             bot.handle_message(message, bot_handler)
             bot.handle_message(message, bot_handler)
             bot.handle_message(message, bot_handler)
@@ -41,7 +41,7 @@ def test_bot_edit_timeout(self) -> None:
 
         error_msg = dict(msg='The time limit for editing this message has passed', result='error')
         with patch('zulip_bots.test_lib.StubBotHandler.update_message', return_value=error_msg):
-            with patch('zulip_bots.simple_lib.SimpleMessageServer.send') as m:
+            with patch('zulip_bots.simple_lib.MockMessageServer.send') as m:
                 bot.handle_message(message, bot_handler)
                 bot.handle_message(message, bot_handler)
 
diff --git a/zulip_bots/zulip_bots/simple_lib.py b/zulip_bots/zulip_bots/simple_lib.py
@@ -17,7 +17,7 @@ def put(self, key, value):
     def get(self, key):
         return self.data[key]
 
-class SimpleMessageServer:
+class MockMessageServer:
     # This class is needed for the incrementor bot, which
     # actually updates messages!
     def __init__(self):
diff --git a/zulip_bots/zulip_bots/terminal.py b/zulip_bots/zulip_bots/terminal.py
@@ -4,7 +4,7 @@
 import argparse
 
 from zulip_bots.finder import import_module_from_source, resolve_bot_path
-from zulip_bots.simple_lib import SimpleMessageServer, TerminalBotHandler
+from zulip_bots.simple_lib import MockMessageServer, TerminalBotHandler
 
 current_dir = os.path.dirname(os.path.abspath(__file__))
 
@@ -49,7 +49,7 @@ def main():
         print("This module does not appear to have a bot handler_class specified.")
         sys.exit(1)
 
-    message_server = SimpleMessageServer()
+    message_server = MockMessageServer()
     bot_handler = TerminalBotHandler(args.bot_config_file, message_server)
     if hasattr(message_handler, 'initialize') and callable(message_handler.initialize):
         message_handler.initialize(bot_handler)
diff --git a/zulip_bots/zulip_bots/test_lib.py b/zulip_bots/zulip_bots/test_lib.py
@@ -13,7 +13,7 @@
 
 from zulip_bots.simple_lib import (
     SimpleStorage,
-    SimpleMessageServer,
+    MockMessageServer,
 )
 
 from zulip_bots.test_file_utils import (
@@ -29,7 +29,7 @@ def __init__(self) -> None:
         self.full_name = 'test-bot'
         self.email = 'test-bot@example.com'
         self.user_id = 0
-        self.message_server = SimpleMessageServer()
+        self.message_server = MockMessageServer()
         self.reset_transcript()
 
     def reset_transcript(self) -> None:
