Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Coinsider splitting @paima/sdk #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SebastienGllmt opened this issue Oct 18, 2023 · 0 comments · Fixed by #254
Closed

Coinsider splitting @paima/sdk #243

SebastienGllmt opened this issue Oct 18, 2023 · 0 comments · Fixed by #254

Comments

@SebastienGllmt
Copy link
Contributor

SebastienGllmt commented Oct 18, 2023

Currently @paima/sdk contains two different set of things:

  1. Things that can only run in the backend (@paima/db and @paima/utils-backend)
  2. Things that can also run in the frontend (the rest of the packages)

As well as @paima/utils that awkwardly contains both

This is not necessarily bad, since it means as a user of Paima you just need a single NPM package.
However, at the same time, it's kind of awkward that @paima/sdk contains some code that if you include in the wrong place will cause an error, and it also means this backend code still has to be compiled in a way that doesn't break frontend bundlers

Probably it's best if we separate these even if it means another NPM package people have to include. Or at least maybe split up the folders inside this repo

This was referenced Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant