GP-4558 fixing a few bugs with actions dialog

ghidragon · ghidragon · commit 6dd517d2d856 · 2024-04-24T15:57:50.000-04:00
diff --git a/Ghidra/Framework/Docking/src/main/java/docking/action/ShowActionChooserDialogAction.java b/Ghidra/Framework/Docking/src/main/java/docking/action/ShowActionChooserDialogAction.java
@@ -46,6 +46,7 @@ public void actionPerformed(ActionContext context) {
 		Tool tool = DockingWindowManager.getActiveInstance().getTool();
 
 		if (focusedWindow instanceof DockingDialog dialog) {
+			context = dialog.getDialogComponent().getActionContext(null);
 			showActionsDialog(tool, dialog, context);
 		}
 		else if (focusedWindow instanceof DockingFrame dockingFrame) {
diff --git a/Ghidra/Framework/Docking/src/main/java/docking/actions/dialog/ActionChooserDialog.java b/Ghidra/Framework/Docking/src/main/java/docking/actions/dialog/ActionChooserDialog.java
@@ -63,6 +63,7 @@ public ActionChooserDialog(ActionsModel model) {
 			"This dialog initialy shows only locally relevant actions. Repeat initial keybinding " +
 				"to show More. Use up down arrows to scroll through list of actions and press" +
 				" enter to invoke selected action. Type text to filter list.");
+		setOkEnabled(false);
 	}
 
 	@Override
@@ -308,7 +309,8 @@ private String getHtmlText(DockingActionIf action, String category, boolean isSe
 			Color fgName = getForeground(); // defaults to list foreground; handles selected state
 			Color fgKeyBinding = isSelected ? getForeground() : Messages.HINT;
 
-			if (!action.isEnabled()) {
+			ActionContext context = model.getContext();
+			if (!(action.isValidContext(context) && action.isEnabledForContext(context))) {
 				fgName = isSelected ? getForeground() : Colors.FOREGROUND_DISABLED;
 				fgKeyBinding = isSelected ? getForeground() : Colors.FOREGROUND_DISABLED;
 				disabledText = isSelected ? " <I>disabled</I>" : "";

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ public void actionPerformed(ActionContext context) {`
`46`	`46`	`Tool tool = DockingWindowManager.getActiveInstance().getTool();`
`47`	`47`
`48`	`48`	`if (focusedWindow instanceof DockingDialog dialog) {`
	`49`	`+ context = dialog.getDialogComponent().getActionContext(null);`
`49`	`50`	`showActionsDialog(tool, dialog, context);`
`50`	`51`	`}`
`51`	`52`	`else if (focusedWindow instanceof DockingFrame dockingFrame) {`