[es] disable AGREEMENT_POSTPONED_ADJ if there is an alternative

jaumeortola · jaumeortola · commit 6a3d5ee21588 · 2024-04-19T11:48:31.000+02:00
diff --git a/languagetool-core/src/main/java/org/languagetool/JLanguageTool.java b/languagetool-core/src/main/java/org/languagetool/JLanguageTool.java
@@ -1093,6 +1093,15 @@ private boolean isRuleActiveForLanguageWithModel(Rule rule, Language language, M
         }
       }
     }
+    if (language.getShortCode().equals("es")) {
+      List<String> disableFrenchRules = Arrays.asList("AGREEMENT_POSTPONED_ADJ");
+      RemoteRuleResult remoteRulesResult = remoteRulesResults.get("AI_ES_GGEC");
+      if (remoteRulesResult != null) {
+        if (remoteRulesResult.isSuccess()) {
+          return !disableFrenchRules.contains(rule.getId());
+        }
+      }
+    }
     return true;
   }
 
diff --git a/languagetool-language-modules/es/src/main/resources/org/languagetool/resource/es/multiwords.txt b/languagetool-language-modules/es/src/main/resources/org/languagetool/resource/es/multiwords.txt
@@ -1,4 +1,7 @@
 #separatorRegExp=[\t;]
+oso panda;NCMS000
+osos panda;NCMP000
+osos pandas;NCMP000
 golden visa;NCFS000
 golden visas;NCFP000
 barriles bomba;NCMP000
diff --git a/languagetool-language-modules/es/src/main/resources/org/languagetool/rules/es/remote-rule-filters.xml b/languagetool-language-modules/es/src/main/resources/org/languagetool/rules/es/remote-rule-filters.xml
@@ -1026,5 +1026,14 @@ To ignore a remote rule match, set the <marker> so that it exactly covers the te
                 <example correction="">Vos <marker>peleás</marker>.</example>
             </rule>
         </rulegroup>
+        <rulegroup id="AI_ES_GGEC_REPLACEMENT_ADJECTIVE_FORM" name="">
+            <rule>
+                <pattern>
+                    <token>osos</token>
+                    <token>panda</token>
+                </pattern>
+                <example correction="">Los <marker>osos panda</marker>.</example>
+            </rule>
+        </rulegroup>
     </category>
 </rules>

Original file line number	Diff line number	Diff line change
`@@ -1093,6 +1093,15 @@ private boolean isRuleActiveForLanguageWithModel(Rule rule, Language language, M`
`1093`	`1093`	`}`
`1094`	`1094`	`}`
`1095`	`1095`	`}`
	`1096`	`+ if (language.getShortCode().equals("es")) {`
	`1097`	`+ List<String> disableFrenchRules = Arrays.asList("AGREEMENT_POSTPONED_ADJ");`
	`1098`	`+ RemoteRuleResult remoteRulesResult = remoteRulesResults.get("AI_ES_GGEC");`
	`1099`	`+ if (remoteRulesResult != null) {`
	`1100`	`+ if (remoteRulesResult.isSuccess()) {`
	`1101`	`+ return !disableFrenchRules.contains(rule.getId());`
	`1102`	`+ }`
	`1103`	`+ }`
	`1104`	`+ }`
`1096`	`1105`	`return true;`
`1097`	`1106`	`}`
`1098`	`1107`