Polish

sambsnyd · sambsnyd · commit 144f318650dd · 2024-06-19T14:32:45.000-07:00
diff --git a/rewrite-maven/src/main/java/org/openrewrite/maven/MavenSettings.java b/rewrite-maven/src/main/java/org/openrewrite/maven/MavenSettings.java
@@ -244,9 +244,9 @@ private ServerConfiguration interpolate(@Nullable ServerConfiguration configurat
                 return null;
             }
             return new ServerConfiguration(
-                    configuration.httpHeaders == null ? null : ListUtils.map(configuration.httpHeaders, this::interpolate),
-                    configuration.connectTimeout == null ? null : configuration.connectTimeout,
-                    configuration.readTimeout == null ? null : configuration.readTimeout
+                    ListUtils.map(configuration.httpHeaders, this::interpolate),
+                    configuration.connectTimeout,
+                    configuration.readTimeout
             );
         }
 
@@ -411,6 +411,7 @@ public static class Server {
         ServerConfiguration configuration;
     }
 
+    @SuppressWarnings("DefaultAnnotationParam")
     @FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)
     @Data
     @With
@@ -420,8 +421,15 @@ public static class ServerConfiguration {
         @JacksonXmlElementWrapper(localName = "httpHeaders", useWrapping = true) // wrapping is disabled by default on MavenXmlMapper
         @Nullable
         List<HttpHeader> httpHeaders;
+        /**
+         * Timeout in milliseconds for establishing a connection.
+         */
         @Nullable
         Long connectTimeout;
+
+        /**
+         * Timeout in milliseconds for reading from the connection.
+         */
         @Nullable
         Long readTimeout;
     }
diff --git a/rewrite-maven/src/main/java/org/openrewrite/maven/tree/MavenRepository.java b/rewrite-maven/src/main/java/org/openrewrite/maven/tree/MavenRepository.java
@@ -31,6 +31,7 @@
 import java.nio.file.Paths;
 import java.time.Duration;
 
+@SuppressWarnings("JavadocReference")
 @JsonIdentityInfo(generator = ObjectIdGenerators.IntSequenceGenerator.class, property = "@ref")
 @FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)
 @EqualsAndHashCode(onlyExplicitlyIncluded = true)
@@ -142,6 +143,7 @@ public static Builder builder() {
         return new Builder();
     }
 
+    @SuppressWarnings("unused")
     @Data
     @FieldDefaults(level = AccessLevel.PRIVATE)
     @Accessors(fluent = true, chain = true)
