From 1838a675716b2144abd7b2afe00f4a30051e38e8 Mon Sep 17 00:00:00 2001 From: Aditya Patwardhan Date: Mon, 29 Aug 2022 18:11:17 -0700 Subject: [PATCH 1/2] Add xml documentation to all ref folders --- tools/packaging/packaging.psm1 | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/packaging/packaging.psm1 b/tools/packaging/packaging.psm1 index 2e278182f9b..283340216d6 100644 --- a/tools/packaging/packaging.psm1 +++ b/tools/packaging/packaging.psm1 @@ -2108,7 +2108,7 @@ function New-ILNugetPackageSource #region ref $refFolder = New-Item (Join-Path $filePackageFolder.FullName "ref/$script:netCoreRuntime") -ItemType Directory -Force - CopyReferenceAssemblies -assemblyName $fileBaseName -refBinPath $refBinPath -refNugetPath $refFolder -assemblyFileList $fileList + CopyReferenceAssemblies -assemblyName $fileBaseName -refBinPath $refBinPath -refNugetPath $refFolder -assemblyFileList $fileList -linux64BinPath $LinuxFxdBinPath #endregion ref $packageRuntimesFolderPath = $packageRuntimesFolder.FullName @@ -2257,7 +2257,8 @@ function CopyReferenceAssemblies [string] $assemblyName, [string] $refBinPath, [string] $refNugetPath, - [string[]] $assemblyFileList + [string[]] $assemblyFileList, + [string] $linux64BinPath ) $supportedRefList = @( @@ -2286,7 +2287,8 @@ function CopyReferenceAssemblies default { $ref_SMA = Join-Path -Path $refBinPath -ChildPath System.Management.Automation.dll $ref_doc = Join-Path -Path $refBinPath -ChildPath System.Management.Automation.xml - Copy-Item $ref_SMA, $ref_doc -Destination $refNugetPath -Force + $self_ref_doc = Join-Path -Path $linux64BinPath -ChildPath "$assemblyName.xml" + Copy-Item $ref_SMA, $ref_doc, $self_ref_doc -Destination $refNugetPath -Force Write-Log "Copied file '$ref_SMA' and '$ref_doc' to '$refNugetPath'" } } From 563a7a2a452ca5761e2f5b7a0352e0fad9740ae3 Mon Sep 17 00:00:00 2001 From: Aditya Patwardhan Date: Tue, 30 Aug 2022 09:25:15 -0700 Subject: [PATCH 2/2] Fix bin path --- tools/packaging/packaging.psm1 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/packaging/packaging.psm1 b/tools/packaging/packaging.psm1 index 283340216d6..775270acaba 100644 --- a/tools/packaging/packaging.psm1 +++ b/tools/packaging/packaging.psm1 @@ -2108,7 +2108,7 @@ function New-ILNugetPackageSource #region ref $refFolder = New-Item (Join-Path $filePackageFolder.FullName "ref/$script:netCoreRuntime") -ItemType Directory -Force - CopyReferenceAssemblies -assemblyName $fileBaseName -refBinPath $refBinPath -refNugetPath $refFolder -assemblyFileList $fileList -linux64BinPath $LinuxFxdBinPath + CopyReferenceAssemblies -assemblyName $fileBaseName -refBinPath $refBinPath -refNugetPath $refFolder -assemblyFileList $fileList -winBinPath $WinFxdBinPath #endregion ref $packageRuntimesFolderPath = $packageRuntimesFolder.FullName @@ -2258,7 +2258,7 @@ function CopyReferenceAssemblies [string] $refBinPath, [string] $refNugetPath, [string[]] $assemblyFileList, - [string] $linux64BinPath + [string] $winBinPath ) $supportedRefList = @( @@ -2287,7 +2287,7 @@ function CopyReferenceAssemblies default { $ref_SMA = Join-Path -Path $refBinPath -ChildPath System.Management.Automation.dll $ref_doc = Join-Path -Path $refBinPath -ChildPath System.Management.Automation.xml - $self_ref_doc = Join-Path -Path $linux64BinPath -ChildPath "$assemblyName.xml" + $self_ref_doc = Join-Path -Path $winBinPath -ChildPath "$assemblyName.xml" Copy-Item $ref_SMA, $ref_doc, $self_ref_doc -Destination $refNugetPath -Force Write-Log "Copied file '$ref_SMA' and '$ref_doc' to '$refNugetPath'" }