From 7624353cb2fdf202a76d5f240fee15e6bdb39610 Mon Sep 17 00:00:00 2001
From: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
Date: Wed, 27 Aug 2025 03:18:19 +0100
Subject: [PATCH] Remove obsolete `CA1026` rule suppression

The FxCop [`CA1026:DefaultParametersShouldNotBeUsed`](https://learn.microsoft.com/previous-versions/visualstudio/visual-studio-2010/ms182135(v=vs.100)) rule was [not ported to roslyn](https://github.com/dotnet/roslyn-analyzers/issues/626).
---
 .../engine/CommandCompletion/CompletionCompleters.cs      | 1 -
 .../utils/perfCounters/CounterSetRegistrarBase.cs         | 2 --
 .../utils/perfCounters/PSPerfCountersMgr.cs               | 8 --------
 3 files changed, 11 deletions(-)

diff --git a/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs b/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
index 880aedb04ce..c3d4deedd54 100644
--- a/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
+++ b/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
@@ -64,7 +64,6 @@ public static IEnumerable<CompletionResult> CompleteCommand(string commandName)
         /// <param name="moduleName"></param>
         /// <param name="commandTypes"></param>
         /// <returns></returns>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public static IEnumerable<CompletionResult> CompleteCommand(string commandName, string moduleName, CommandTypes commandTypes = CommandTypes.All)
         {
             var runspace = Runspace.DefaultRunspace;
diff --git a/src/System.Management.Automation/utils/perfCounters/CounterSetRegistrarBase.cs b/src/System.Management.Automation/utils/perfCounters/CounterSetRegistrarBase.cs
index f9a08b76a87..1ea57a16912 100644
--- a/src/System.Management.Automation/utils/perfCounters/CounterSetRegistrarBase.cs
+++ b/src/System.Management.Automation/utils/perfCounters/CounterSetRegistrarBase.cs
@@ -95,7 +95,6 @@ public abstract class CounterSetRegistrarBase
         /// based on Provider Id, counterSetId, counterSetInstanceType, a collection
         /// with counters information and an optional counterSetName.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         protected CounterSetRegistrarBase(
             Guid providerId,
             Guid counterSetId,
@@ -220,7 +219,6 @@ public class PSCounterSetRegistrar : CounterSetRegistrarBase
         /// <summary>
         /// Constructor that creates an instance of PSCounterSetRegistrar.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public PSCounterSetRegistrar(
             Guid providerId,
             Guid counterSetId,
diff --git a/src/System.Management.Automation/utils/perfCounters/PSPerfCountersMgr.cs b/src/System.Management.Automation/utils/perfCounters/PSPerfCountersMgr.cs
index 761de0c6360..7a49a5c6f9f 100644
--- a/src/System.Management.Automation/utils/perfCounters/PSPerfCountersMgr.cs
+++ b/src/System.Management.Automation/utils/perfCounters/PSPerfCountersMgr.cs
@@ -162,7 +162,6 @@ public bool AddCounterSetInstance(CounterSetRegistrarBase counterSetRegistrarIns
         /// by 'stepAmount'.
         /// Otherwise, updates the denominator component by 'stepAmount'.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public bool UpdateCounterByValue(
             Guid counterSetId,
             int counterId,
@@ -193,7 +192,6 @@ public bool UpdateCounterByValue(
         /// by 'stepAmount'.
         /// Otherwise, updates the denominator component by 'stepAmount'.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public bool UpdateCounterByValue(
             Guid counterSetId,
             string counterName,
@@ -224,7 +222,6 @@ public bool UpdateCounterByValue(
         /// by 'stepAmount'.
         /// Otherwise, updates the denominator component by 'stepAmount'.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public bool UpdateCounterByValue(
             string counterSetName,
             int counterId,
@@ -264,7 +261,6 @@ public bool UpdateCounterByValue(
         /// by 'stepAmount'.
         /// Otherwise, updates the denominator component by 'stepAmount'.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public bool UpdateCounterByValue(
             string counterSetName,
             string counterName,
@@ -303,7 +299,6 @@ public bool UpdateCounterByValue(
         /// to 'counterValue'.
         /// Otherwise, updates the denominator component to 'counterValue'.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public bool SetCounterValue(
             Guid counterSetId,
             int counterId,
@@ -334,7 +329,6 @@ public bool SetCounterValue(
         /// to 'counterValue'.
         /// Otherwise, updates the denominator component to 'counterValue'.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public bool SetCounterValue(
             Guid counterSetId,
             string counterName,
@@ -365,7 +359,6 @@ public bool SetCounterValue(
         /// to 'counterValue'.
         /// Otherwise, updates the denominator component to 'counterValue'.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public bool SetCounterValue(
             string counterSetName,
             int counterId,
@@ -404,7 +397,6 @@ public bool SetCounterValue(
         /// to 'counterValue'.
         /// Otherwise, updates the denominator component to 'counterValue'.
         /// </summary>
-        [SuppressMessage("Microsoft.Design", "CA1026:DefaultParametersShouldNotBeUsed")]
         public bool SetCounterValue(
             string counterSetName,
             string counterName,