Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/v7.6] Fix a regression in the API CompletionCompleters.CompleteFilename() that causes null reference exception #26487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 1 commit into from
Dec 5, 2025
Merged

[release/v7.6] Fix a regression in the API CompletionCompleters.CompleteFilename() that causes null reference exception #26487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4580,8 +4580,8 @@ internal static IEnumerable<CompletionResult> CompleteFilename(CompletionContext
return CommandCompletion.EmptyCompletionResult;
}

var lastAst = context.RelatedAsts[^1];
if (lastAst.Parent is UsingStatementAst usingStatement
var lastAst = context.RelatedAsts?[^1];
if (lastAst?.Parent is UsingStatementAst usingStatement
&& usingStatement.UsingStatementKind is UsingStatementKind.Module or UsingStatementKind.Assembly
&& lastAst.Extent.File is not null)
{
Expand Down
23 changes: 23 additions & 0 deletions test/powershell/Host/TabCompletion/BugFix.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,27 @@ Describe "Tab completion bug fix" -Tags "CI" {
$Runspace.Dispose()
}
}

It "Issue#26277 - [CompletionCompleters]::CompleteFilename('') should work" {
$testDir = Join-Path $TestDrive "TempTestDir"
$file1 = Join-Path $testDir "abc.ps1"
$file2 = Join-Path $testDir "def.py"

New-Item -ItemType Directory -Path $testDir > $null
New-Item -ItemType File -Path $file1 > $null
New-Item -ItemType File -Path $file2 > $null

try {
Push-Location -Path $testDir
$result = [System.Management.Automation.CompletionCompleters]::CompleteFilename("")
$result | Should -Not -Be $null
$result | Measure-Object | ForEach-Object -MemberName Count | Should -Be 2

$item1, $item2 = @($result)
$item1.ListItemText | Should -BeExactly 'abc.ps1'
$item2.ListItemText | Should -BeExactly 'def.py'
} finally {
Pop-Location
}
}
}
Loading