Do not emit instruction teq if divisor is non-zero immediate value in FastISel implementation (llvm#135768)

yingopq · qethu · commit e37e048740e7 · 2025-05-22T08:45:05.000+08:00
Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
diff --git a/llvm/lib/Target/Mips/MipsFastISel.cpp b/llvm/lib/Target/Mips/MipsFastISel.cpp
@@ -1947,7 +1947,10 @@ bool MipsFastISel::selectDivRem(const Instruction *I, unsigned ISDOpcode) {
     return false;
 
   emitInst(DivOpc).addReg(Src0Reg).addReg(Src1Reg);
-  emitInst(Mips::TEQ).addReg(Src1Reg).addReg(Mips::ZERO).addImm(7);
+  if (!isa<ConstantInt>(I->getOperand(1)) ||
+      dyn_cast<ConstantInt>(I->getOperand(1))->isZero()) {
+    emitInst(Mips::TEQ).addReg(Src1Reg).addReg(Mips::ZERO).addImm(7);
+  }
 
   Register ResultReg = createResultReg(&Mips::GPR32RegClass);
   if (!ResultReg)
diff --git a/llvm/test/CodeGen/Mips/Fast-ISel/div-imm.ll b/llvm/test/CodeGen/Mips/Fast-ISel/div-imm.ll
@@ -0,0 +1,29 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -march=mipsel -mcpu=mips32 -O0 -relocation-model=pic | FileCheck %s
+
+define i32 @div_imm_non_zero(i32 signext %a) nounwind {
+; CHECK-LABEL: div_imm_non_zero:
+; CHECK:       # %bb.0: # %entry
+; CHECK-NEXT:    addiu $1, $zero, 1234
+; CHECK-NEXT:    div $zero, $4, $1
+; CHECK-NEXT:    mflo $2
+; CHECK-NEXT:    jr $ra
+; CHECK-NEXT:    nop
+entry:
+  %div = sdiv i32 %a, 1234
+  ret i32 %div
+}
+
+define i32 @div_imm_zero(i32 signext %a) nounwind {
+; CHECK-LABEL: div_imm_zero:
+; CHECK:       # %bb.0: # %entry
+; CHECK-NEXT:    addiu $1, $zero, 0
+; CHECK-NEXT:    div $zero, $4, $zero
+; CHECK-NEXT:    teq $zero, $zero, 7
+; CHECK-NEXT:    mflo $2
+; CHECK-NEXT:    jr $ra
+; CHECK-NEXT:    nop
+entry:
+  %div = sdiv i32 %a, 0
+  ret i32 %div
+}
