leaks: fix some leaks in the tests

Edward Thomson · Edward Thomson · commit 17442b28f9ba · 2016-03-31T10:41:33.000-04:00
diff --git a/tests/config/write.c b/tests/config/write.c
@@ -712,10 +712,13 @@ void test_config_write__repeated(void)
 	cl_git_pass(git_config_set_string(cfg, "sample.prefix.setting2", "someValue2"));
 	cl_git_pass(git_config_set_string(cfg, "sample.prefix.setting3", "someValue3"));
 	cl_git_pass(git_config_set_string(cfg, "sample.prefix.setting4", "someValue4"));
+	git_config_free(cfg);
 
 	cl_git_pass(git_config_open_ondisk(&cfg, filename));
 
 	cl_git_pass(git_futils_readbuffer(&result, filename));
 	cl_assert_equal_s(expected, result.ptr);
 	git_buf_free(&result);
+
+	git_config_free(cfg);
 }
diff --git a/tests/iterator/index.c b/tests/iterator/index.c
@@ -970,7 +970,9 @@ void test_iterator_index__pathlist_with_directory(void)
 	cl_git_pass(git_iterator_for_index(&i, g_repo, index, &i_opts));
 	expect_iterator_items(i, 4, NULL, 4, NULL);
 	git_iterator_free(i);
+
 	git_index_free(index);
+	git_tree_free(tree);
 	git_vector_free(&filelist);
 }
 
diff --git a/tests/iterator/tree.c b/tests/iterator/tree.c
@@ -1020,6 +1020,7 @@ void test_iterator_tree__pathlist_with_directory(void)
 	expect_iterator_items(i, expected_len2, expected2, expected_len2, expected2);
 	git_iterator_free(i);
 
+	git_tree_free(tree);
 	git_vector_free(&filelist);
 }
 
@@ -1048,6 +1049,7 @@ void test_iterator_tree__pathlist_with_directory_include_tree_nodes(void)
 	expect_iterator_items(i, expected_len, expected, expected_len, expected);
 	git_iterator_free(i);
 
+	git_tree_free(tree);
 	git_vector_free(&filelist);
 }
 
@@ -1070,7 +1072,9 @@ void test_iterator_tree__pathlist_no_match(void)
 
 	cl_git_pass(git_iterator_for_tree(&i, tree, &i_opts));
 	cl_assert_equal_i(GIT_ITEROVER, git_iterator_current(&entry, i));
+	git_iterator_free(i);
 
+	git_tree_free(tree);
 	git_vector_free(&filelist);
 }
 
diff --git a/tests/iterator/workdir.c b/tests/iterator/workdir.c
@@ -1030,6 +1030,8 @@ static void create_paths(const char *root, int depth)
 				create_paths(fullpath.ptr, (depth - 1));
 		}
 	}
+
+	git_buf_free(&fullpath);
 }
 
 void test_iterator_workdir__pathlist_for_deeply_nested_item(void)
diff --git a/tests/status/worktree.c b/tests/status/worktree.c
@@ -1211,15 +1211,15 @@ void test_status_worktree__with_directory_in_pathlist(void)
 	const git_status_entry *status;
 	size_t i, entrycount;
 	bool native_ignore_case;
+	char *subdir_path = "subdir";
 
 	cl_git_pass(git_repository_index(&index, repo));
 	native_ignore_case =
 			(git_index_caps(index) & GIT_INDEXCAP_IGNORE_CASE) != 0;
 	git_index_free(index);
 
+	opts.pathspec.strings = &subdir_path;
 	opts.pathspec.count = 1;
-	opts.pathspec.strings = malloc(opts.pathspec.count * sizeof(char *));
-	opts.pathspec.strings[0] = "subdir";
 	opts.flags =
 			GIT_STATUS_OPT_DEFAULTS |
 			GIT_STATUS_OPT_INCLUDE_UNMODIFIED |
@@ -1240,6 +1240,8 @@ void test_status_worktree__with_directory_in_pathlist(void)
 			status->index_to_workdir->old_file.path);
 	}
 
+	git_status_list_free(statuslist);
+
 	opts.show = GIT_STATUS_SHOW_INDEX_ONLY;
 	git_status_list_new(&statuslist, repo, &opts);
 
@@ -1255,6 +1257,8 @@ void test_status_worktree__with_directory_in_pathlist(void)
 			status->head_to_index->old_file.path);
 	}
 
+	git_status_list_free(statuslist);
+
 	opts.show = GIT_STATUS_SHOW_INDEX_AND_WORKDIR;
 	git_status_list_new(&statuslist, repo, &opts);
 
@@ -1269,5 +1273,7 @@ void test_status_worktree__with_directory_in_pathlist(void)
 			testrepo2_subdir_paths[i],
 			status->index_to_workdir->old_file.path);
 	}
+
+	git_status_list_free(statuslist);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -970,7 +970,9 @@ void test_iterator_index__pathlist_with_directory(void)`
`970`	`970`	`cl_git_pass(git_iterator_for_index(&i, g_repo, index, &i_opts));`
`971`	`971`	`expect_iterator_items(i, 4, NULL, 4, NULL);`
`972`	`972`	`git_iterator_free(i);`
	`973`	`+`
`973`	`974`	`git_index_free(index);`
	`975`	`+ git_tree_free(tree);`
`974`	`976`	`git_vector_free(&filelist);`
`975`	`977`	`}`
`976`	`978`
Original file line number	Diff line number	Diff line change
`@@ -1020,6 +1020,7 @@ void test_iterator_tree__pathlist_with_directory(void)`
`1020`	`1020`	`expect_iterator_items(i, expected_len2, expected2, expected_len2, expected2);`
`1021`	`1021`	`git_iterator_free(i);`
`1022`	`1022`
	`1023`	`+ git_tree_free(tree);`
`1023`	`1024`	`git_vector_free(&filelist);`
`1024`	`1025`	`}`
`1025`	`1026`
`@@ -1048,6 +1049,7 @@ void test_iterator_tree__pathlist_with_directory_include_tree_nodes(void)`
`1048`	`1049`	`expect_iterator_items(i, expected_len, expected, expected_len, expected);`
`1049`	`1050`	`git_iterator_free(i);`
`1050`	`1051`
	`1052`	`+ git_tree_free(tree);`
`1051`	`1053`	`git_vector_free(&filelist);`
`1052`	`1054`	`}`
`1053`	`1055`
`@@ -1070,7 +1072,9 @@ void test_iterator_tree__pathlist_no_match(void)`
`1070`	`1072`
`1071`	`1073`	`cl_git_pass(git_iterator_for_tree(&i, tree, &i_opts));`
`1072`	`1074`	`cl_assert_equal_i(GIT_ITEROVER, git_iterator_current(&entry, i));`
	`1075`	`+ git_iterator_free(i);`
`1073`	`1076`
	`1077`	`+ git_tree_free(tree);`
`1074`	`1078`	`git_vector_free(&filelist);`
`1075`	`1079`	`}`
`1076`	`1080`
Original file line number	Diff line number	Diff line change
`@@ -1030,6 +1030,8 @@ static void create_paths(const char *root, int depth)`
`1030`	`1030`	`create_paths(fullpath.ptr, (depth - 1));`
`1031`	`1031`	`}`
`1032`	`1032`	`}`
	`1033`	`+`
	`1034`	`+ git_buf_free(&fullpath);`
`1033`	`1035`	`}`
`1034`	`1036`
`1035`	`1037`	`void test_iterator_workdir__pathlist_for_deeply_nested_item(void)`